Changeset 32331 for trunk/src/wp-includes/meta.php

Timestamp:

05/01/2015 04:37:35 PM (10 years ago)

Author:

boonebgorges

Message:

Allow metadata to be deleted when meta_value matches 0 or '0'.

In delete_metadata(), be stricter about when to ignore a falsey value of
$meta_value.

For backward compatibility, an empty string for $meta_value is equivalent to
null or false.

Props sc0ttkclark.
Fixes #32224.

File:

• trunk/src/wp-includes/meta.php (modified) (2 diffs)

trunk/src/wp-includes/meta.php

@@ -295 +295 @@
  * @global wpdb $wpdb WordPress database abstraction object.
  *
- * @param string $meta_type Type of object metadata is for (e.g., comment, post, or user)
- * @param int $object_id ID of the object metadata is for
- * @param string $meta_key Metadata key
- * @param mixed $meta_value Optional. Metadata value. Must be serializable if non-scalar. If specified, only delete metadata entries
- *      with this value. Otherwise, delete all entries with the specified meta_key.
- * @param bool $delete_all Optional, default is false. If true, delete matching metadata entries
- *      for all objects, ignoring the specified object_id. Otherwise, only delete matching
- *      metadata entries for the specified object_id.
+ * @param string $meta_type  Type of object metadata is for (e.g., comment, post, or user)
+ * @param int    $object_id  ID of the object metadata is for
+ * @param string $meta_key   Metadata key
+ * @param mixed  $meta_value Optional. Metadata value. Must be serializable if non-scalar. If specified, only delete
+ *                           metadata entries with this value. Otherwise, delete all entries with the specified meta_key.
+ *                           Pass `null, `false`, or an empty string to skip this check. (For backward compatibility,
+ *                           it is not possible to pass an empty string to delete those entries with an empty string
+ *                           for a value.)
+ * @param bool   $delete_all Optional, default is false. If true, delete matching metadata entries for all objects,
+ *                           ignoring the specified object_id. Otherwise, only delete matching metadata entries for
+ *                           the specified object_id.
  * @return bool True on successful delete, false on failure.
  */
@@ -357 +360 @@
         $query .= $wpdb->prepare(" AND $type_column = %d", $object_id );
 
-    if ( $meta_value )
+    if ( '' !== $meta_value && null !== $meta_value && false !== $meta_value )
         $query .= $wpdb->prepare(" AND meta_value = %s", $meta_value );