Changeset 32391 for branches/3.7/tests/phpunit/tests/comment.php

Timestamp:

05/06/2015 07:16:41 PM (11 years ago)

Author:

mdawaffe

Message:

WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding(), as it behaves differently to MySQL's character encoding conversion.

Merge of [32364] to the 3.7 branch.

Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.

See #32165.

File:

• branches/3.7/tests/phpunit/tests/comment.php (modified) (2 diffs)

branches/3.7/tests/phpunit/tests/comment.php

@@ -24 +24 @@
                 }
 
-                $post_id = $this->factory->post->create();
+                $u = $this->factory->user->create();
+                $post_id = $this->factory->post->create( array( 'post_author' => $u ) );
 
                 $data = array(
@@ -37 +38 @@
                 );
 
+                add_filter( 'pre_option_moderation_notify', '__return_zero' );
                 $id = wp_new_comment( $data );
+                remove_filter( 'pre_option_moderation_notify', '__return_zero' );
 
-                $this->assertFalse( $id );
+                $this->assertEmpty( $id );
 
                 // Cleanup.