Changeset 32480

Timestamp:

05/10/2015 12:31:47 AM (10 years ago)

Author:

azaozz

Message:

Widgets:

• Fix dragging to the bottom of the screen.
• Fix hiding of the dragged widget when dragging over a closed sidebar.
• Fix the admin menu position and scrolling when all widget containers are folded.

Fixes #32094 for trunk.

Location:

trunk/src/wp-admin

Files:

• css/widgets.css (modified) (2 diffs)
• js/common.js (modified) (1 diff)
• js/widgets.js (modified) (8 diffs)

trunk/src/wp-admin/css/widgets.css

@@ -351 +351 @@
 }
 
+.js .widgets-holder-wrap.closed .widget.ui-sortable-helper {
+    display: block;
+}
+
 /* Hide Widget Settings by Default */
 .widget-inside,
@@ -507 +511 @@
 }
 
+#available-widgets .widget.ui-draggable-dragging .widget-top {
+    cursor: move;
+}
+
 /* =Media Queries
 -------------------------------------------------------------- */

trunk/src/wp-admin/js/common.js

@@ -861 +861 @@
     setPinMenu();
 
-    $document.on( 'wp-window-resized.pin-menu postboxes-columnchange.pin-menu postbox-toggled.pin-menu wp-collapse-menu.pin-menu wp-scroll-start.pin-menu', setPinMenu );
+    $document.on( 'wp-pin-menu wp-window-resized.pin-menu postboxes-columnchange.pin-menu postbox-toggled.pin-menu wp-collapse-menu.pin-menu wp-scroll-start.pin-menu', setPinMenu );
 });
 

trunk/src/wp-admin/js/widgets.js

@@ -2 +2 @@
 var wpWidgets;
 (function($) {
+    var $document = $( document );
 
 wpWidgets = {
@@ -23 +24 @@
                 $wrap.addClass('closed');
             }
+
+            $document.triggerHandler( 'wp-pin-menu' );
         });
 
         $('#widgets-left .sidebar-name').click( function() {
             $(this).closest('.widgets-holder-wrap').toggleClass('closed');
+            $document.triggerHandler( 'wp-pin-menu' );
         });
 
@@ -90 +94 @@
             helper: 'clone',
             zIndex: 100,
-            containment: 'document',
+            containment: '#wpwrap',
             start: function( event, ui ) {
                 var chooser = $(this).find('.widgets-chooser');
@@ -120 +124 @@
             cursor: 'move',
             distance: 2,
-            containment: 'document',
+            containment: '#wpwrap',
             start: function( event, ui ) {
                 var height, $this = $(this),
@@ -175 +179 @@
                     wpWidgets.save( $widget, 0, 0, 1 );
                     $widget.find('input.add_new').val('');
-                    $( document ).trigger( 'widget-added', [ $widget ] );
+                    $document.trigger( 'widget-added', [ $widget ] );
                 }
 
@@ -382 +386 @@
                     $( 'div.widget-content', widget ).html( r );
                     wpWidgets.appendTitle( widget );
-                    $( document ).trigger( 'widget-updated', [ widget ] );
+                    $document.trigger( 'widget-updated', [ widget ] );
                 }
             }
@@ -447 +451 @@
         widget.find( 'input.add_new' ).val('');
 
-        $( document ).trigger( 'widget-added', [ widget ] );
+        $document.trigger( 'widget-added', [ widget ] );
 
         /*
@@ -490 +494 @@
 };
 
-$(document).ready( function(){ wpWidgets.init(); } );
+$document.ready( function(){ wpWidgets.init(); } );
 
 })(jQuery);