Make WordPress Core

Changeset 32502


Ignore:
Timestamp:
05/13/2015 09:26:22 PM (9 years ago)
Author:
wonderboymusic
Message:

In views/button/select-mode-toggle, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's toggleBulkEditHandler method.

Props afercia.
Fixes #32324.

Location:
trunk/src/wp-includes/js
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/js/media-grid.js

    r32466 r32502  
    312312        if ( this.controller.isModeActive( 'select' ) ) {
    313313            this.model.set( 'text', l10n.cancelSelection );
    314             children.not( '.media-button' ).hide();
     314            children.not( '.spinner, .media-button' ).hide();
    315315            this.$el.show();
    316316            toolbar.$( '.delete-selected-button' ).removeClass( 'hidden' );
     
    320320            toolbar.$el.css( 'width', '' );
    321321            toolbar.$( '.delete-selected-button' ).addClass( 'hidden' );
    322             children.not( '.spinner, .media-button' ).show();
     322            children.not( '.media-button' ).show();
    323323            this.controller.state().get( 'selection' ).reset();
    324324        }
  • trunk/src/wp-includes/js/media/views/button/select-mode-toggle.js

    r31494 r32502  
    4848        if ( this.controller.isModeActive( 'select' ) ) {
    4949            this.model.set( 'text', l10n.cancelSelection );
    50             children.not( '.media-button' ).hide();
     50            children.not( '.spinner, .media-button' ).hide();
    5151            this.$el.show();
    5252            toolbar.$( '.delete-selected-button' ).removeClass( 'hidden' );
     
    5656            toolbar.$el.css( 'width', '' );
    5757            toolbar.$( '.delete-selected-button' ).addClass( 'hidden' );
    58             children.not( '.spinner, .media-button' ).show();
     58            children.not( '.media-button' ).show();
    5959            this.controller.state().get( 'selection' ).reset();
    6060        }
Note: See TracChangeset for help on using the changeset viewer.