Changeset 32517 for trunk/src/wp-admin/includes/class-wp-media-list-table.php

Timestamp:

05/19/2015 08:49:59 PM (11 years ago)

Author:

wonderboymusic

Message:

In WP_Media_List_Table::get_views(), declare $num_posts explicitly before looping.

See #32444.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -66 +66 @@
                 $total_orphans = $wpdb->get_var( "SELECT COUNT( * ) FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status != 'trash' AND post_parent < 1" );
                 $matches = wp_match_mime_types(array_keys($post_mime_types), array_keys($_num_posts));
-                foreach ( $matches as $type => $reals )
-                        foreach ( $reals as $real )
+                $num_posts = array();
+                foreach ( $matches as $type => $reals ) {
+                        foreach ( $reals as $real ) {
                                 $num_posts[$type] = ( isset( $num_posts[$type] ) ) ? $num_posts[$type] + $_num_posts[$real] : $_num_posts[$real];
-
+                        }
+                }
                 $selected = empty( $_GET['attachment-filter'] ) ? ' selected="selected"' : '';
                 $type_links['all'] = "<option value=''$selected>" . sprintf( _nx( 'All (%s)', 'All (%s)', $_total_posts, 'uploaded files' ), number_format_i18n( $_total_posts ) ) . '</option>';