Changeset 32638

Timestamp:

05/28/2015 04:05:30 PM (11 years ago)

Author:

boonebgorges

Message:

Improve tests for is_email_address_unsafe().

• Move to a separate file for better organization and method names.
• Use a dataProvider when appropriate, for better readability.
• Add a test for splitting the banned domain list on line breaks.

See #20459, #21730.

Location:

trunk/tests/phpunit/tests

Files:

• multisite.php (modified) (1 diff)
• multisite/isEmailAddressUnsafe.php (added)

trunk/tests/phpunit/tests/multisite.php

@@ -37 +37 @@
                 $this->assertEquals( $user->user_email, $reg_blog[ count( $reg_blog )-1 ] );
         }
-
-        /**
-         * @ticket 21570
-         */
-        function test_aggressiveness_of_is_email_address_unsafe() {
-                update_site_option( 'banned_email_domains', array( 'bar.com', 'foo.co' ) );
-
-                foreach ( array( 'test@bar.com', 'test@foo.bar.com', 'test@foo.co', 'test@subdomain.foo.co' ) as $email_address ) {
-                        $this->assertTrue( is_email_address_unsafe( $email_address ), "$email_address should be UNSAFE" );
-                }
-
-                foreach ( array( 'test@foobar.com', 'test@foo-bar.com', 'test@foo.com', 'test@subdomain.foo.com' ) as $email_address ) {
-                        $this->assertFalse( is_email_address_unsafe( $email_address ), "$email_address should be SAFE" );
-                }
-        }
-
-        /**
-         * @ticket 25046
-         */
-        function test_case_sensitivity_of_is_email_address_unsafe() {
-                update_site_option( 'banned_email_domains', array( 'baR.com', 'Foo.co', 'barfoo.COM', 'BAZ.com' ) );
-
-                foreach ( array( 'test@Bar.com', 'tEst@bar.com', 'test@barFoo.com', 'tEst@foo.bar.com', 'test@baz.Com' ) as $email_address ) {
-                        $this->assertTrue( is_email_address_unsafe( $email_address ), "$email_address should be UNSAFE" );
-                }
-
-                foreach ( array( 'test@Foobar.com', 'test@Foo-bar.com', 'tEst@foobar.com', 'test@Subdomain.Foo.com', 'test@fooBAz.com' ) as $email_address ) {
-                        $this->assertFalse( is_email_address_unsafe( $email_address ), "$email_address should be SAFE" );
-                }
-
-        }
 }