Changeset 32647 for trunk/tests/phpunit/tests/post/wpUniquePostSlug.php

Timestamp:

05/29/2015 12:52:17 PM (11 years ago)

Author:

boonebgorges

Message:

Disallow post slugs that will result in permalinks that conflict with date archive URLs.

On certain permalink structures, a numeric post slug will result in a post
permalink that conflicts with a date archive URL. For example, with permastruct
/%year%/%monthnum%/%postname%/, a post published in May 2015 with slug
'15' will result in a URL (/2015/05/15/) that conflicts with the archive
for May 15, 2015.

To avoid this problem, wp_unique_post_slug() rejects a requested slug when it
would generate a conflict of this type. Thus, in our example, '15' would
become '15-2'.

Props valendesigns, boonebgorges, Denis-de-Bernardy, loushou.
See #5305.

File:

• trunk/tests/phpunit/tests/post/wpUniquePostSlug.php (modified) (1 diff)

trunk/tests/phpunit/tests/post/wpUniquePostSlug.php

@@ -165 +165 @@
                 $this->assertSame( 'foo', $actual );
         }
+
+        /**
+         * @ticket 5305
+         */
+        public function test_slugs_resulting_in_permalinks_that_resemble_year_archives_should_be_suffixed() {
+                global $wp_rewrite;
+                $wp_rewrite->init();
+                $wp_rewrite->set_permalink_structure( '/%postname%/' );
+                $wp_rewrite->flush_rules();
+
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'post',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_unique_post_slug( '2015', $p, 'publish', 'post', 0 );
+                $this->assertEquals( '2015-2', $found );
+
+                $wp_rewrite->set_permalink_structure( '' );
+                flush_rewrite_rules();
+        }
+
+        /**
+         * @ticket 5305
+         */
+        public function test_yearlike_slugs_should_not_be_suffixed_if_permalink_structure_does_not_result_in_a_clash_with_year_archives() {
+                global $wp_rewrite;
+                $wp_rewrite->init();
+                $wp_rewrite->set_permalink_structure( '/%year%/%postname%/' );
+                $wp_rewrite->flush_rules();
+
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'post',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_unique_post_slug( '2015', $p, 'publish', 'post', 0 );
+                $this->assertEquals( '2015', $found );
+
+                $wp_rewrite->set_permalink_structure( '' );
+                flush_rewrite_rules();
+        }
+
+        /**
+         * @ticket 5305
+         */
+        public function test_slugs_resulting_in_permalinks_that_resemble_month_archives_should_be_suffixed() {
+                global $wp_rewrite;
+                $wp_rewrite->init();
+                $wp_rewrite->set_permalink_structure( '/%year%/%postname%/' );
+                $wp_rewrite->flush_rules();
+
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'post',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_unique_post_slug( '11', $p, 'publish', 'post', 0 );
+                $this->assertEquals( '11-2', $found );
+
+                $wp_rewrite->set_permalink_structure( '' );
+                flush_rewrite_rules();
+        }
+
+        /**
+         * @ticket 5305
+         */
+        public function test_monthlike_slugs_should_not_be_suffixed_if_permalink_structure_does_not_result_in_a_clash_with_month_archives() {
+                global $wp_rewrite;
+                $wp_rewrite->init();
+                $wp_rewrite->set_permalink_structure( '/%year%/foo/%postname%/' );
+                $wp_rewrite->flush_rules();
+
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'post',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_unique_post_slug( '11', $p, 'publish', 'post', 0 );
+                $this->assertEquals( '11', $found );
+
+                $wp_rewrite->set_permalink_structure( '' );
+                flush_rewrite_rules();
+        }
+
+        /**
+         * @ticket 5305
+         */
+        public function test_monthlike_slugs_should_not_be_suffixed_for_invalid_month_numbers() {
+                global $wp_rewrite;
+                $wp_rewrite->init();
+                $wp_rewrite->set_permalink_structure( '/%year%/%postname%/' );
+                $wp_rewrite->flush_rules();
+
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'post',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_unique_post_slug( '13', $p, 'publish', 'post', 0 );
+                $this->assertEquals( '13', $found );
+
+                $wp_rewrite->set_permalink_structure( '' );
+                flush_rewrite_rules();
+        }
+
+        /**
+         * @ticket 5305
+         */
+        public function test_slugs_resulting_in_permalinks_that_resemble_day_archives_should_be_suffixed() {
+                global $wp_rewrite;
+                $wp_rewrite->init();
+                $wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%postname%/' );
+                $wp_rewrite->flush_rules();
+
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'post',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_unique_post_slug( '30', $p, 'publish', 'post', 0 );
+                $this->assertEquals( '30-2', $found );
+
+                $wp_rewrite->set_permalink_structure( '' );
+                flush_rewrite_rules();
+        }
+
+        /**
+         * @ticket 5305
+         */
+        public function test_daylike_slugs_should_not_be_suffixed_if_permalink_structure_does_not_result_in_a_clash_with_day_archives() {
+                global $wp_rewrite;
+                $wp_rewrite->init();
+                $wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
+                $wp_rewrite->flush_rules();
+
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'post',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_unique_post_slug( '30', $p, 'publish', 'post', 0 );
+                $this->assertEquals( '30', $found );
+
+                $wp_rewrite->set_permalink_structure( '' );
+                flush_rewrite_rules();
+        }
+
+        /**
+         * @ticket 5305
+         */
+        public function test_daylike_slugs_should_not_be_suffixed_for_invalid_day_numbers() {
+                global $wp_rewrite;
+                $wp_rewrite->init();
+                $wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%postname%/' );
+                $wp_rewrite->flush_rules();
+
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'post',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_unique_post_slug( '32', $p, 'publish', 'post', 0 );
+                $this->assertEquals( '32', $found );
+
+                $wp_rewrite->set_permalink_structure( '' );
+                flush_rewrite_rules();
+        }
 }