Changeset 32686 for trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

Timestamp:

06/03/2015 03:07:22 PM (11 years ago)

Author:

helen

Message:

List tables: tighten up primary column handling for plugins and multisite themes.

These shouldn't be able to have their primary column reassigned by default. Also removes the has-row-actions class as these list tables always have row actions visible and the JS for visual toggling conflicts. The column-primary class remains.

props stephdau.
see #25408.

File:

• trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -582 +582 @@
         list( $columns, $hidden, $sortable, $primary ) = $this->get_column_info();
 
-        $extra_class = ' has-row-actions column-primary';
+        $extra_class = ' column-primary';
 
         foreach ( $columns as $column_name => $column_display_name ) {
@@ -720 +720 @@
 
     /**
-     * Get the name of default primary column for this specific list table.
+     * Get the name of primary column for this specific list table.
      *
      * @since 4.3.0
      * @access protected
      *
-     * @return string Name for the default primary column, in this case, 'plugin'.
-     */
-    protected function get_default_primary_column_name() {
+     * @return string Unalterable name for the primary column, in this case, 'plugin'.
+     */
+    protected function get_primary_column_name() {
         return 'plugin';
     }