Changeset 32692

Timestamp:

06/04/2015 05:28:07 PM (10 years ago)

Author:

boonebgorges

Message:

In wp_notify_moderator(), don't throw notice when comment belongs to a post with no author.

Props Oxymoron.
Fixes #32566.

Location:

trunk

Files:

• src/wp-includes/pluggable.php (modified) (1 diff)
• tests/phpunit/tests/comment.php (modified) (1 diff)

trunk/src/wp-includes/pluggable.php

@@ -1551 +1551 @@
     // Send to the administration and to the post author if the author can modify the comment.
     $emails = array( get_option( 'admin_email' ) );
-    if ( user_can( $user->ID, 'edit_comment', $comment_id ) && ! empty( $user->user_email ) ) {
+    if ( $user && user_can( $user->ID, 'edit_comment', $comment_id ) && ! empty( $user->user_email ) ) {
         if ( 0 !== strcasecmp( $user->user_email, get_option( 'admin_email' ) ) )
             $emails[] = $user->user_email;

trunk/tests/phpunit/tests/comment.php

@@ -149 +149 @@
         }
     }
+
+    /**
+     * @ticket 32566
+     */
+    public function test_wp_notify_moderator_should_not_throw_notice_when_post_author_is_0() {
+        $p = $this->factory->post->create( array(
+            'post_author' => 0,
+        ) );
+
+        $c = $this->factory->comment->create( array(
+            'comment_post_ID' => $p,
+        ) );
+
+        $this->assertTrue( wp_notify_moderator( $c ) );
+    }
 }