Changeset 32713 for trunk/src/wp-includes/meta.php

Timestamp:

06/09/2015 05:41:35 PM (10 years ago)

Author:

boonebgorges

Message:

Avoid returning duplicate matches when using a meta query in WP_User_Query.

A meta_query containing an OR relation can result in the same record matching
multiple clauses, leading to duplicate results. The previous prevention against
duplicates [18178] #17582 became unreliable in 4.1 when WP_Meta_Query
introduced support for nested clauses. The current changeset adds a new method
WP_Meta_Query::has_or_relation() for checking whether an OR relation
appears anywhere in the query, and uses the new method in WP_User_Query to
enforce distinct results as necessary.

Props maxxsnake.
Fixes #32592.

File:

• trunk/src/wp-includes/meta.php (modified) (3 diffs)

trunk/src/wp-includes/meta.php

@@ -955 +955 @@
 
     /**
+     * Whether the query contains any OR relations.
+     *
+     * @since 4.3.0
+     * @access protected
+     * @var bool
+     */
+    protected $has_or_relation = false;
+
+    /**
      * Constructor.
      *
@@ -1047 +1056 @@
         if ( isset( $relation ) && 'OR' === strtoupper( $relation ) ) {
             $clean_queries['relation'] = 'OR';
+            $this->has_or_relation = true;
 
         /*
@@ -1579 +1589 @@
         return apply_filters( 'meta_query_find_compatible_table_alias', $alias, $clause, $parent_query, $this ) ;
     }
+
+    /**
+     * Check whether the current query has any OR relations.
+     *
+     * In some cases, the presence of an OR relation somewhere in the query will require the use of a DISTINCT or
+     * GROUP BY keyword in the SELECT clause. The current method can be used in these cases to determine whether
+     * such a clause is necessary.
+     *
+     * @since 4.3.0
+     *
+     * @return bool True if the query contains any OR relations, otherwise false.
+     */
+    public function has_or_relation() {
+        return $this->has_or_relation;
+    }
 }