Changeset 32717

Timestamp:

06/10/2015 01:45:11 AM (10 years ago)

Author:

helen

Message:

List tables:

• Avoid notices in custom list tables that manually set $_column_headers. Any plugins using this for a specific purpose should update.
• Restore a special class name in the users list table.

props georgestephanis, stephdau.
see #25408.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-list-table.php (modified) (1 diff)
• class-wp-users-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -851 +851 @@
      */
     protected function get_column_info() {
-        if ( isset( $this->_column_headers ) )
+        if ( isset( $this->_column_headers ) && is_array( $this->_column_headers ) && count( $this->_column_headers ) >= 4 ) {
             return $this->_column_headers;
+        }
 
         $columns = get_column_headers( $this->screen );

trunk/src/wp-admin/includes/class-wp-users-list-table.php

@@ -411 +411 @@
             if ( $primary === $column_name ) {
                 $classes .= ' has-row-actions column-primary';
+            }
+            if ( 'posts' === $column_name ) {
+                $classes .= ' num'; // Special case for that column
             }
 
@@ -438 +441 @@
                         break;
                     case 'posts':
-                        $attributes = 'class="posts column-posts num"' . $style;
                         if ( $numposts > 0 ) {
                             $r .= "<a href='edit.php?author=$user_object->ID' class='edit'>";