Changeset 32724 for trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

06/10/2015 07:46:39 PM (10 years ago)

Author:

helen

Message:

List tables: Use a class instead of inline styles for hidden columns.

fixes #32608.

File:

• trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -435 +435 @@
 
         foreach ( $columns as $column_name => $column_display_name ) {
-            $style = '';
-            if ( in_array( $column_name, $hidden ) )
-                $style = ' style="display:none;"';
+            $extra_classes = '';
+            if ( in_array( $column_name, $hidden ) ) {
+                $extra_classes .= ' hidden';
+            }
 
             switch ( $column_name ) {
@@ -444 +445 @@
                     break;
                 case 'name':
-                    echo "<td class='theme-title column-primary'$style><strong>" . $theme->display('Name') . "</strong>";
+                    echo "<td class='theme-title column-primary{$extra_classes}'><strong>" . $theme->display('Name') . "</strong>";
                     echo $this->row_actions($actions, true);
                     echo "</td>";
                     break;
                 case 'description':
-                    echo "<td class='column-description desc'$style>";
+                    echo "<td class='column-description desc{$extra_classes}'>";
                     if ( $theme->errors() ) {
                         $pre = $status == 'broken' ? __( 'Broken Theme:' ) . ' ' : '';
@@ -488 +489 @@
 
                 default:
-                    echo "<td class='$column_name column-$column_name'$style>";
+                    echo "<td class='$column_name column-$column_name{$extra_classes}'>";
 
                     /**