Changeset 32727

Timestamp:

06/12/2015 01:04:04 PM (11 years ago)

Author:

boonebgorges

Message:

Introduce class argument to wp_dropdown_pages().

This new argument allows devs to specify the 'class' attribute of the select
element.

Props ramiy, voldemortensen.
Fixes #30082.

Location:

trunk

Files:

• src/wp-includes/post-template.php (modified) (4 diffs)
• tests/phpunit/tests/post/template.php (modified) (1 diff)

trunk/src/wp-includes/post-template.php

@@ -991 +991 @@
  * @since 2.1.0
  * @since 4.2.0 The `$value_field` argument was added.
+ * @since 4.3.0 The `$class` argument was added.
  *
  * @param array|string $args {
@@ -1003 +1004 @@
  *                                               Default 'page_id'.
  *     @type string       $id                    Value for the 'id' attribute of the select element.
+ *     @type string       $class                 Value for the 'class' attribute of the select element. Default: none.
  *                                               Defaults to the value of `$name`.
  *     @type string       $show_option_none      Text to display for showing no pages. Default empty (does not display).
@@ -1017 +1019 @@
                 'selected' => 0, 'echo' => 1,
                 'name' => 'page_id', 'id' => '',
+                'class' => '',
                 'show_option_none' => '', 'show_option_no_change' => '',
                 'option_none_value' => '',
@@ -1032 +1035 @@
 
         if ( ! empty( $pages ) ) {
-                $output = "<select name='" . esc_attr( $r['name'] ) . "' id='" . esc_attr( $r['id'] ) . "'>\n";
+                $class = '';
+                if ( ! empty( $r['class'] ) ) {
+                        $class = " class='" . esc_attr( $r['class'] ) . "'";
+                }
+
+                $output = "<select name='" . esc_attr( $r['name'] ) . "'" . $class . " id='" . esc_attr( $r['id'] ) . "'>\n";
                 if ( $r['show_option_no_change'] ) {
                         $output .= "\t<option value=\"-1\">" . $r['show_option_no_change'] . "</option>\n";

trunk/tests/phpunit/tests/post/template.php

@@ -200 +200 @@
 
         /**
+         * @ticket 30082
+         */
+        public function test_wp_dropdown_pages_should_not_contain_class_attribute_when_no_class_is_passed() {
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'page',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_dropdown_pages( array(
+                        'echo' => 0,
+                ) );
+
+                $this->assertNotRegExp( '/<select[^>]+class=\'/', $found );
+        }
+
+        /**
+         * @ticket 30082
+         */
+        public function test_wp_dropdown_pages_should_obey_class_parameter() {
+                $p = $this->factory->post->create( array(
+                        'post_type' => 'page',
+                        'post_name' => 'foo',
+                ) );
+
+                $found = wp_dropdown_pages( array(
+                        'echo' => 0,
+                        'class' => 'bar',
+                ) );
+
+                $this->assertRegExp( '/<select[^>]+class=\'bar\'/', $found );
+        }
+
+        /**
          * @ticket 31389
          */