Changeset 32730

Timestamp:

06/12/2015 05:18:38 PM (8 years ago)

Author:

wonderboymusic

Message:

Don't loosely compare functions that return bool against a literal bool.

See #32444.

Location:

trunk/src/wp-admin

Files:

• includes/export.php (modified) (1 diff)
• includes/menu.php (modified) (1 diff)
• includes/ms.php (modified) (1 diff)
• network/site-new.php (modified) (1 diff)
• network/site-users.php (modified) (1 diff)

trunk/src/wp-admin/includes/export.php

@@ -134 +134 @@
      */
     function wxr_cdata( $str ) {
-        if ( seems_utf8( $str ) == false )
+        if ( ! seems_utf8( $str ) ) {
             $str = utf8_encode( $str );
-
+        }
         // $str = ent2ncr(esc_html($str));
         $str = '<![CDATA[' . str_replace( ']]>', ']]]]><![CDATA[>', $str ) . ']]>';

trunk/src/wp-admin/includes/menu.php

@@ -183 +183 @@
 foreach ( $menu as $id => $data ) {
     if ( 0 == strcmp('wp-menu-separator', $data[4] ) ) {
-        if (false == $separator_found) {
+        if ( ! $separator_found ) {
             $separator_found = true;
         } else {

trunk/src/wp-admin/includes/ms.php

@@ -454 +454 @@
  */
 function fix_import_form_size( $size ) {
-    if ( upload_is_user_over_quota( false ) == true )
+    if ( upload_is_user_over_quota( false ) ) {
         return 0;
-
+    }
     $available = get_upload_space_available();
     return min( $size, $available );

trunk/src/wp-admin/network/site-new.php

@@ -77 +77 @@
         $password = wp_generate_password( 12, false );
         $user_id = wpmu_create_user( $domain, $password, $email );
-        if ( false == $user_id )
+        if ( false === $user_id )
             wp_die( __( 'There was an error creating the user.' ) );
         else

trunk/src/wp-admin/network/site-users.php

@@ -71 +71 @@
                 $user_id = wpmu_create_user( esc_html( strtolower( $user['username'] ) ), $password, esc_html( $user['email'] ) );
 
-                if ( false == $user_id ) {
+                if ( false === $user_id ) {
                     $update = 'err_new_dup';
                 } else {