Changeset 32733 for trunk/src/wp-signup.php

Timestamp:

06/12/2015 05:47:16 PM (8 years ago)

Author:

wonderboymusic

Message:

$status shouldn't be loosely compared to true in wp_xmlrpc_server::wp_deleteComment().
$initial shouldn't be loosely compared to true in get_calendar().
current_user_can() shouldn't be loosely compared to false in kses_init()
$get_all shouldn't be loosely compared to true in get_blog_details().
is_array() and in_array() shouldn't be loosely compared in wpmu_validate_user_signup().
$result should by strictly compared in check_ajax_referer().
wp_verify_nonce() should by strictly compared in _show_post_preview().
is_user_logged_in() should not be loosly compared against false in wp-signup.php.

See #32444.

File:

• trunk/src/wp-signup.php (modified) (2 diffs)

trunk/src/wp-signup.php

@@ -8 +8 @@
 require( dirname( __FILE__ ) . '/wp-blog-header.php' );
 
-if ( is_array( get_site_option( 'illegal_names' )) && isset( $_GET[ 'new' ] ) && in_array( $_GET[ 'new' ], get_site_option( 'illegal_names' ) ) == true ) {
+if ( is_array( get_site_option( 'illegal_names' )) && isset( $_GET[ 'new' ] ) && in_array( $_GET[ 'new' ], get_site_option( 'illegal_names' ) ) ) {
     wp_redirect( network_home_url() );
     die();
@@ -701 +701 @@
             if ( is_user_logged_in() && ( $active_signup == 'all' || $active_signup == 'blog' ) )
                 signup_another_blog($newblogname);
-            elseif ( is_user_logged_in() == false && ( $active_signup == 'all' || $active_signup == 'user' ) )
+            elseif ( ! is_user_logged_in() && ( $active_signup == 'all' || $active_signup == 'user' ) )
                 signup_user( $newblogname, $user_email );
-            elseif ( is_user_logged_in() == false && ( $active_signup == 'blog' ) )
+            elseif ( ! is_user_logged_in() && ( $active_signup == 'blog' ) )
                 _e( 'Sorry, new registrations are not allowed at this time.' );
             else