Changeset 32752

Timestamp:

06/13/2015 03:13:47 PM (11 years ago)

Author:

wonderboymusic

Message:

In WP_Posts_List_Table, move the <th> markup out of ->column_cb().

See #29881, [32740].

File:

• trunk/src/wp-admin/includes/class-wp-posts-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -683 +683 @@
          */
         public function column_cb( $post ) {
-                $can_edit_post = current_user_can( 'edit_post', $post->ID );
-                $title = _draft_or_post_title();
-                ?>
-                <th scope="row" class="check-column">
-                <?php if ( $can_edit_post ) { ?>
-                        <label class="screen-reader-text" for="cb-select-<?php the_ID(); ?>"><?php printf( __( 'Select %s' ), $title ); ?></label>
+                if ( current_user_can( 'edit_post', $post->ID ) ): ?>
+                        <label class="screen-reader-text" for="cb-select-<?php the_ID(); ?>"><?php
+                                printf( __( 'Select %s' ), _draft_or_post_title() );
+                        ?></label>
                         <input id="cb-select-<?php the_ID(); ?>" type="checkbox" name="post[]" value="<?php the_ID(); ?>" />
                         <div class="locked-indicator"></div>
-                <?php } ?>
-                </th>
-                <?php
+                <?php endif;
         }
 
@@ -981 +977 @@
 
                         if ( 'cb' === $column_name ) {
+                                echo '<th scope="row" class="check-column">';
+
                                 $this->column_cb( $item );
+
+                                echo '</th>';
                         } else {
                                 echo "<td $attributes>";