Changeset 32777 for trunk

Timestamp:

06/15/2015 03:19:30 AM (11 years ago)

Author:

dd32

Message:

Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
See #32435

Location:

trunk/src/wp-admin

Files:

• css/edit.css (modified) (2 diffs)
• css/forms.css (modified) (2 diffs)
• js/updates.js (modified) (2 diffs)

trunk/src/wp-admin/css/edit.css

@@ -522 +522 @@
         position: fixed;
         top: 30%;
+        max-height: 70%;
         left: 50%;
         width: 450px;
@@ -530 +531 @@
         line-height: 1.5;
         z-index: 1000005;
+        overflow-y: auto;
 }
 

trunk/src/wp-admin/css/forms.css

@@ -863 +863 @@
 .request-filesystem-credentials-dialog .notification-dialog {
         top: 15%;
+        max-height: 85%;
 }
 
@@ -1172 +1173 @@
                 width: 100%;
                 height: 100%;
+                max-height: 100%;
                 position: fixed;
                 top: 0;
                 margin: 0;
                 left: 0;
-                overflow-y: auto;
         }
 }

trunk/src/wp-admin/js/updates.js

@@ -468 +468 @@
                 });
 
+                // Hide SSH fields when not selected
+                $( '#request-filesystem-credentials-dialog input[name="connection_type"]' ).on( 'change', function() {
+                        $( this ).parents( 'form' ).find( '#private_key, #public_key' ).parents( 'label' ).toggle( ( 'ssh' == $( this ).val() ) );
+                }).change();
+
                 // Click handler for plugin updates in List Table view.
                 $( '.plugin-update-tr' ).on( 'click', '.update-link', function( e ) {
@@ -491 +496 @@
                 } );
 
-                //
                 $( '#plugin_update_from_iframe' ).on( 'click' , function( e ) {
                         var target,     data;