Changeset 32827

Timestamp:

06/17/2015 11:12:08 PM (10 years ago)

Author:

azaozz

Message:

Press This: show error message when the user is attempting to add a category that already exists.
Fixes #32339.

File:

• trunk/src/wp-admin/includes/class-wp-press-this.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-press-this.php

@@ -202 +202 @@
             }
 
-            // @todo Find a more performant to check existence, maybe get_term() with a separate parent check.
-            if ( ! $cat_id = term_exists( $cat_name, $taxonomy->name, $parent ) ) {
-                $cat_id = wp_insert_term( $cat_name, $taxonomy->name, array( 'parent' => $parent ) );
-            }
+            // @todo Find a more performant way to check existence, maybe get_term() with a separate parent check.
+            if ( term_exists( $cat_name, $taxonomy->name, $parent ) ) {
+                if ( count( $names ) === 1 ) {
+                    wp_send_json_error( array( 'errorMessage' => __( 'This category already exists.' ) ) );
+                } else {
+                    continue;
+                }
+            }
+
+            $cat_id = wp_insert_term( $cat_name, $taxonomy->name, array( 'parent' => $parent ) );
 
             if ( is_wp_error( $cat_id ) ) {