Changeset 32850 for trunk/tests/phpunit/tests/formatting/JSEscape.php

Timestamp:

06/18/2015 09:59:10 PM (10 years ago)

Author:

wonderboymusic

Message:

Since PHP 5.2.3, the htmlspecialchars() function has an optional $double_encode parameter, which we can now use. This will save us a few expensive kses/html decoding calls.

Adds unit tests.

Props miqrogroove.
Fixes #17780.

File:

• trunk/tests/phpunit/tests/formatting/JSEscape.php (modified) (1 diff)

trunk/tests/phpunit/tests/formatting/JSEscape.php

@@ -24 +24 @@
 
     function test_js_escape_amp() {
-        $out = esc_js('foo & bar &baz; '');
-        $this->assertEquals("foo & bar &baz; '", $out);
+        $out = esc_js('foo & bar &baz;  ');
+        $this->assertEquals("foo & bar &baz;  ", $out);
     }
 
     function test_js_escape_quote_entity() {
         $out = esc_js('foo ' bar ' baz &');
-        $this->assertEquals("foo \\' bar \\' baz &", $out);
+        $this->assertEquals("foo \\' bar \\' baz &", $out);
     }