Changeset 32850 for trunk/tests/phpunit/tests/formatting/WPSpecialchars.php

Timestamp:

06/18/2015 09:59:10 PM (9 years ago)

Author:

wonderboymusic

Message:

Since PHP 5.2.3, the htmlspecialchars() function has an optional $double_encode parameter, which we can now use. This will save us a few expensive kses/html decoding calls.

Adds unit tests.

Props miqrogroove.
Fixes #17780.

File:

• trunk/tests/phpunit/tests/formatting/WPSpecialchars.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/WPSpecialchars.php

@@ -18 +18 @@
         // Allowed entities should be unchanged
         foreach ( $allowedentitynames as $ent ) {
+            if ( 'apos' == $ent ) {
+                // But for some reason, PHP doesn't allow '
+                continue;
+            }
             $ent = '&' . $ent . ';';
             $this->assertEquals( $ent, _wp_specialchars( $ent ) );
@@ -40 +44 @@
         $this->assertEquals( $source, _wp_specialchars($source) );
     }
+
+    /**
+     * Check some of the double-encoding features for entity references.
+     *
+     * @ticket 17780
+     * @dataProvider data_double_encoding
+     */
+    function test_double_encoding( $input, $output ) {
+        return $this->assertEquals( $output, _wp_specialchars( $input, ENT_NOQUOTES, false, true ) );
+    }
+
+    function data_double_encoding() {
+        return array(
+            array(
+                'This & that, this & that, — " " Ú   " " " " " $ ×',
+                'This & that, this & that, — " " Ú   " " " " " $ ×',
+            ),
+            array(
+                '&& && && &;',
+                '&& && && &;',
+            ),
+            array(
+                '&garbage; &***; &aaaa; &0000; &####; &;;',
+                '&garbage; &***; &aaaa; &0000; &####; &;;',
+            ),
+        );
+    }
+
+    /**
+     * Check some of the double-encoding features for entity references.
+     *
+     * @ticket 17780
+     * @dataProvider data_no_double_encoding
+     */
+    function test_no_double_encoding( $input, $output ) {
+        return $this->assertEquals( $output, _wp_specialchars( $input, ENT_NOQUOTES, false, false ) );
+    }
+
+    function data_no_double_encoding() {
+        return array(
+            array(
+                'This & that, this & that, — " " Ú   " " " " " $ ×',
+                'This & that, this & that, — " " Ú   " " " " " $ ×',
+            ),
+            array(
+                '&& && && &;',
+                '&& && && &;',
+            ),
+            array(
+                '&garbage; &***; &aaaa; &0000; &####; &;;',
+                '&garbage; &***; &aaaa; &0000; &####; &;;',
+            ),
+        );
+    }
 }