Changeset 32892

Timestamp:

06/20/2015 07:49:43 PM (10 years ago)

Author:

ocean90

Message:

Customizer: Improve handling of posts with no title.

Use the #%d (no title) string as a fallback which is already used on the nav menus screen.
Add a translator comment to all occurrences of the #%d (no title) string.

see #32576.

Location:

trunk/src/wp-includes

Files:

• class-wp-customize-nav-menus.php (modified) (4 diffs)
• nav-menu.php (modified) (2 diffs)
• post-template.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-customize-nav-menus.php

@@ -110 +110 @@
             ) );
             foreach ( $posts as $post ) {
+                $post_title = $post->post_title;
+                if ( '' === $post_title ) {
+                    /* translators: %d: ID of a post */
+                    $post_title = sprintf( __( '#%d (no title)' ), $post->ID );
+                }
                 $items[] = array(
                     'id'         => "post-{$post->ID}",
-                    'title'      => html_entity_decode( get_the_title( $post ), ENT_QUOTES, get_bloginfo( 'charset' ) ),
+                    'title'      => html_entity_decode( $post_title, ENT_QUOTES, get_bloginfo( 'charset' ) ),
                     'type'       => 'post_type',
                     'type_label' => get_post_type_object( $post->post_type )->labels->singular_name,
@@ -217 +222 @@
         if ( $get_posts->post_count ) {
             foreach ( $get_posts->posts as $post ) {
+                $post_title = $post->post_title;
+                if ( '' === $post_title ) {
+                    /* translators: %d: ID of a post */
+                    $post_title = sprintf( __( '#%d (no title)' ), $post->ID );
+                }
                 $results[] = array(
                     'id'         => 'post-' . $post->ID,
@@ -223 +233 @@
                     'object'     => $post->post_type,
                     'object_id'  => intval( $post->ID ),
-                    'title'      => html_entity_decode( get_the_title( $post ), ENT_QUOTES, get_bloginfo( 'charset' ) ),
+                    'title'      => html_entity_decode( $post_title, ENT_QUOTES, get_bloginfo( 'charset' ) ),
                 );
             }
@@ -271 +281 @@
             'itemTypes'            => $this->available_item_types(),
             'l10n'                 => array(
-                'untitled'          => _x( '(no label)', 'Missing menu item navigation label.' ),
+                'untitled'          => _x( '(no label)', 'missing menu item navigation label' ),
                 'custom_label'      => __( 'Custom Link' ),
                 /* translators: %s: Current menu location */

trunk/src/wp-includes/nav-menu.php

@@ -703 +703 @@
 
                 if ( '' === $original_title ) {
+                    /* translators: %d: ID of a post */
                     $original_title = sprintf( __( '#%d (no title)' ), $original_object->ID );
                 }
@@ -765 +766 @@
             $menu_item->type_label = $object->labels->singular_name;
 
-            if ( '' === $menu_item->post_title )
+            if ( '' === $menu_item->post_title ) {
+                /* translators: %d: ID of a post */
                 $menu_item->post_title = sprintf( __( '#%d (no title)' ), $menu_item->ID );
+            }
 
             $menu_item->title = $menu_item->post_title;

trunk/src/wp-includes/post-template.php

@@ -1419 +1419 @@
 
         if ( '' === $page->post_title ) {
+            /* translators: %d: ID of a post */
             $page->post_title = sprintf( __( '#%d (no title)' ), $page->ID );
         }
@@ -1509 +1510 @@
         $title = $page->post_title;
         if ( '' === $title ) {
+            /* translators: %d: ID of a post */
             $title = sprintf( __( '#%d (no title)' ), $page->ID );
         }