Changeset 32892 for trunk/src/wp-includes/class-wp-customize-nav-menus.php

Timestamp:

06/20/2015 07:49:43 PM (11 years ago)

Author:

ocean90

Message:

Customizer: Improve handling of posts with no title.

Use the #%d (no title) string as a fallback which is already used on the nav menus screen.
Add a translator comment to all occurrences of the #%d (no title) string.

see #32576.

File:

• trunk/src/wp-includes/class-wp-customize-nav-menus.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-customize-nav-menus.php

@@ -110 +110 @@
                         ) );
                         foreach ( $posts as $post ) {
+                                $post_title = $post->post_title;
+                                if ( '' === $post_title ) {
+                                        /* translators: %d: ID of a post */
+                                        $post_title = sprintf( __( '#%d (no title)' ), $post->ID );
+                                }
                                 $items[] = array(
                                         'id'         => "post-{$post->ID}",
-                                        'title'      => html_entity_decode( get_the_title( $post ), ENT_QUOTES, get_bloginfo( 'charset' ) ),
+                                        'title'      => html_entity_decode( $post_title, ENT_QUOTES, get_bloginfo( 'charset' ) ),
                                         'type'       => 'post_type',
                                         'type_label' => get_post_type_object( $post->post_type )->labels->singular_name,
@@ -217 +222 @@
                 if ( $get_posts->post_count ) {
                         foreach ( $get_posts->posts as $post ) {
+                                $post_title = $post->post_title;
+                                if ( '' === $post_title ) {
+                                        /* translators: %d: ID of a post */
+                                        $post_title = sprintf( __( '#%d (no title)' ), $post->ID );
+                                }
                                 $results[] = array(
                                         'id'         => 'post-' . $post->ID,
@@ -223 +233 @@
                                         'object'     => $post->post_type,
                                         'object_id'  => intval( $post->ID ),
-                                        'title'      => html_entity_decode( get_the_title( $post ), ENT_QUOTES, get_bloginfo( 'charset' ) ),
+                                        'title'      => html_entity_decode( $post_title, ENT_QUOTES, get_bloginfo( 'charset' ) ),
                                 );
                         }
@@ -271 +281 @@
                         'itemTypes'            => $this->available_item_types(),
                         'l10n'                 => array(
-                                'untitled'          => _x( '(no label)', 'Missing menu item navigation label.' ),
+                                'untitled'          => _x( '(no label)', 'missing menu item navigation label' ),
                                 'custom_label'      => __( 'Custom Link' ),
                                 /* translators: %s: Current menu location */