Changeset 32945

Timestamp:

06/25/2015 07:30:00 PM (10 years ago)

Author:

wonderboymusic

Message:

After [32796], improve the accessibility and markup for instances of touch_time().

Props rianrietveld, afercia.
Fixes #31714.

Location:

trunk/src/wp-admin

Files:

• css/list-tables.css (modified) (3 diffs)
• edit-form-comment.php (modified) (1 diff)
• includes/class-wp-posts-list-table.php (modified) (1 diff)
• includes/meta-boxes.php (modified) (1 diff)
• includes/template.php (modified) (2 diffs)

trunk/src/wp-admin/css/list-tables.css

@@ -318 +318 @@
 }
 
-table.media .column-title .media-info p { 
-    margin-bottom: 0.2em; 
+table.media .column-title .media-info p {
+    margin-bottom: 0.2em;
 }
 
@@ -878 +878 @@
 }
 
+.inline-edit-row fieldset.inline-edit-date label {
+    display: inline-block;
+    margin: 0;
+    line-height: 1.5;
+    vertical-align: baseline;
+}
+
 .inline-edit-row fieldset label.inline-edit-tags {
     margin-top: 0;
@@ -887 +894 @@
 }
 
-.inline-edit-row fieldset label span.title {
+.inline-edit-row fieldset label span.title,
+.inline-edit-row fieldset.inline-edit-date legend {
     display: block;
     float: left;
     width: 5em;
     line-height: 2.5;
+}
+
+#posts-filter fieldset.inline-edit-date legend {
+    padding: 0;
+}
+
+.inline-edit-row fieldset.inline-edit-date select {
+    margin: 1px;
+    line-height: 28px;
 }
 

trunk/src/wp-admin/edit-form-comment.php

@@ -93 +93 @@
 <span id="timestamp"><?php printf( $stamp, $date ); ?></span>
 <a href="#edit_timestamp" class="edit-timestamp hide-if-no-js"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit date and time' ); ?></span></a>
-<div id='timestampdiv' class='hide-if-js'><?php touch_time(('editcomment' == $action), 0); ?></div>
+<fieldset id='timestampdiv' class='hide-if-js'>
+<legend class="screen-reader-text"><?php _e( 'Date and time' ); ?></legend>
+<?php touch_time( ( 'editcomment' === $action ), 0 ); ?>
+</fieldset>
 </div>
 

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1212 +1212 @@
 
     <?php if ( !$bulk ) : ?>
-            <label><span class="title"><?php _e( 'Date' ); ?></span></label>
-            <div class="inline-edit-date">
+            <fieldset class="inline-edit-date">
+            <legend><span class="title"><?php _e( 'Date' ); ?></span></legend>
                 <?php touch_time( 1, 1, 0, 1 ); ?>
-            </div>
+            </fieldset>
             <br class="clear" />
     <?php endif; // $bulk

trunk/src/wp-admin/includes/meta-boxes.php

@@ -207 +207 @@
     <?php printf($stamp, $date); ?></span>
     <a href="#edit_timestamp" class="edit-timestamp hide-if-no-js"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit date and time' ); ?></span></a>
-    <div id="timestampdiv" class="hide-if-js"><?php touch_time(($action == 'edit'), 1); ?></div>
+    <fieldset id="timestampdiv" class="hide-if-js">
+    <legend class="screen-reader-text"><?php _e( 'Date and time' ); ?></legend>
+    <?php touch_time( ( $action === 'edit' ), 1 ); ?>
+    </fieldset>
 </div><?php // /misc-pub-section ?>
 <?php endif; ?>

trunk/src/wp-admin/includes/template.php

@@ -782 +782 @@
     $cur_mn = gmdate( 'i', $time_adj );
 
-    $month = '<label for="mm" class="screen-reader-text">' . __( 'Month' ) . '</label><select ' . ( $multi ? '' : 'id="mm" ' ) . 'name="mm"' . $tab_index_attribute . ">\n";
+    $month = '<label><span class="screen-reader-text">' . __( 'Month' ) . '</span><select ' . ( $multi ? '' : 'id="mm" ' ) . 'name="mm"' . $tab_index_attribute . ">\n";
     for ( $i = 1; $i < 13; $i = $i +1 ) {
         $monthnum = zeroise($i, 2);
@@ -789 +789 @@
         $month .= sprintf( __( '%1$s-%2$s' ), $monthnum, $wp_locale->get_month_abbrev( $wp_locale->get_month( $i ) ) ) . "</option>\n";
     }
-    $month .= '</select>';
-
-    $day = '<label for="jj" class="screen-reader-text">' . __( 'Day' ) . '</label><input type="text" ' . ( $multi ? '' : 'id="jj" ' ) . 'name="jj" value="' . $jj . '" size="2" maxlength="2"' . $tab_index_attribute . ' autocomplete="off" />';
-    $year = '<label for="aa" class="screen-reader-text">' . __( 'Year' ) . '</label><input type="text" ' . ( $multi ? '' : 'id="aa" ' ) . 'name="aa" value="' . $aa . '" size="4" maxlength="4"' . $tab_index_attribute . ' autocomplete="off" />';
-    $hour = '<label for="hh" class="screen-reader-text">' . __( 'Hour' ) . '</label><input type="text" ' . ( $multi ? '' : 'id="hh" ' ) . 'name="hh" value="' . $hh . '" size="2" maxlength="2"' . $tab_index_attribute . ' autocomplete="off" />';
-    $minute = '<label for="mn" class="screen-reader-text">' . __( 'Minute' ) . '</label><input type="text" ' . ( $multi ? '' : 'id="mn" ' ) . 'name="mn" value="' . $mn . '" size="2" maxlength="2"' . $tab_index_attribute . ' autocomplete="off" />';
+    $month .= '</select></label>';
+
+    $day = '<label><span class="screen-reader-text">' . __( 'Day' ) . '</span><input type="text" ' . ( $multi ? '' : 'id="jj" ' ) . 'name="jj" value="' . $jj . '" size="2" maxlength="2"' . $tab_index_attribute . ' autocomplete="off" /></label>';
+    $year = '<label><span class="screen-reader-text">' . __( 'Year' ) . '</span><input type="text" ' . ( $multi ? '' : 'id="aa" ' ) . 'name="aa" value="' . $aa . '" size="4" maxlength="4"' . $tab_index_attribute . ' autocomplete="off" /></label>';
+    $hour = '<label><span class="screen-reader-text">' . __( 'Hour' ) . '</span><input type="text" ' . ( $multi ? '' : 'id="hh" ' ) . 'name="hh" value="' . $hh . '" size="2" maxlength="2"' . $tab_index_attribute . ' autocomplete="off" /></label>';
+    $minute = '<label><span class="screen-reader-text">' . __( 'Minute' ) . '</span><input type="text" ' . ( $multi ? '' : 'id="mn" ' ) . 'name="mn" value="' . $mn . '" size="2" maxlength="2"' . $tab_index_attribute . ' autocomplete="off" /></label>';
 
     echo '<div class="timestamp-wrap">';