Changeset 32984 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

06/28/2015 05:45:49 AM (10 years ago)

Author:

SergeyBiryukov

Message:

List tables: Select All should not be a column header.

It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -994 +994 @@
             }
 
+            $tag = ( 'cb' === $column_key ) ? 'td' : 'th';
+            $scope = ( 'th' === $tag ) ? 'scope="col"' : '';
             $id = $with_id ? "id='$column_key'" : '';
 
@@ -999 +1001 @@
                 $class = "class='" . join( ' ', $class ) . "'";
 
-            echo "<th scope='col' $id $class>$column_display_name</th>";
+            echo "<$tag $scope $id $class>$column_display_name</$tag>";
         }
     }