WordPress.org

Make WordPress Core


Ignore:
Timestamp:
06/28/2015 03:26:41 PM (4 years ago)
Author:
jorbin
Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-ftp-pure.php

    r26868 r32990  
    2828class ftp extends ftp_base {
    2929
     30    function __construct($verb=FALSE, $le=FALSE) {
     31        parent::__construct(false, $verb, $le);
     32    }
     33
    3034    function ftp($verb=FALSE, $le=FALSE) {
    3135        $this->__construct($verb, $le);
    32     }
    33 
    34     function __construct($verb=FALSE, $le=FALSE) {
    35         parent::__construct(false, $verb, $le);
    3636    }
    3737
Note: See TracChangeset for help on using the changeset viewer.