Changeset 32990 for trunk/src/wp-admin/includes/class-ftp.php

Timestamp:

06/28/2015 03:26:41 PM (9 years ago)

Author:

jorbin

Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: ​https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:

• trunk/src/wp-admin/includes/class-ftp.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-ftp.php

@@ -122 +122 @@
 
     /* Constructor */
-    function ftp_base($port_mode=FALSE) {
-        $this->__construct($port_mode);
-    }
-
     function __construct($port_mode=FALSE, $verb=FALSE, $le=FALSE) {
         $this->LocalEcho=$le;
@@ -156 +152 @@
         if(strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') $this->OS_local=FTP_OS_Windows;
         elseif(strtoupper(substr(PHP_OS, 0, 3)) === 'MAC') $this->OS_local=FTP_OS_Mac;
+    }
+
+    function ftp_base($port_mode=FALSE) {
+        $this->__construct($port_mode);
     }