WordPress.org

Make WordPress Core


Ignore:
Timestamp:
06/28/2015 03:26:41 PM (4 years ago)
Author:
jorbin
Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-pclzip.php

    r12042 r32990  
    213213  //   created. Use create() for that.
    214214  // --------------------------------------------------------------------------------
    215   function PclZip($p_zipname)
     215  function __construct($p_zipname)
    216216  {
    217217
     
    229229    // ----- Return
    230230    return;
     231  }
     232
     233  public function PclZip($p_zipname) {
     234    self::__construct($p_zipname);
    231235  }
    232236  // --------------------------------------------------------------------------------
Note: See TracChangeset for help on using the changeset viewer.