WordPress.org

Make WordPress Core


Ignore:
Timestamp:
06/28/2015 03:26:41 PM (4 years ago)
Author:
jorbin
Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-pop3.php

    r17677 r32990  
    4545                                //  manually
    4646
    47     function POP3 ( $server = '', $timeout = '' ) {
     47    /**
     48     * PHP5 constructor.
     49     */
     50    function __construct ( $server = '', $timeout = '' ) {
    4851        settype($this->BUFFER,"integer");
    4952        if( !empty($server) ) {
     
    6265        return true;
    6366    }
     67
     68    /**
     69     * PHP4 constructor.
     70     */
     71    public function POP3( $server = '', $timeout = '' ) {
     72        self::__construct( $server, $timeout );
     73    }
    6474
    6575    function update_timer () {
Note: See TracChangeset for help on using the changeset viewer.