Changeset 32990 for trunk/src/wp-includes/rss.php

Timestamp:

06/28/2015 03:26:41 PM (11 years ago)

Author:

jorbin

Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: ​https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:

• trunk/src/wp-includes/rss.php (modified) (4 diffs)

trunk/src/wp-includes/rss.php

@@ -56 +56 @@
     var $_CONTENT_CONSTRUCTS = array('content', 'summary', 'info', 'title', 'tagline', 'copyright');
 
-    function MagpieRSS ($source) {
+    /**
+     * PHP5 constructor.
+     */
+    function __construct( $source ) {
 
         # if PHP xml isn't compiled in, die
@@ -96 +99 @@
 
         $this->normalize();
+    }
+
+    /**
+     * PHP4 constructor.
+     */
+    public function MagpieRSS( $source ) {
+        self::__construct( $source );
     }
 
@@ -710 +720 @@
     var $ERROR      = '';           // accumulate error messages
 
-    function RSSCache ($base='', $age='') {
+    /**
+     * PHP5 constructor.
+     */
+    function __construct( $base = '', $age = '' ) {
         $this->BASE_CACHE = WP_CONTENT_DIR . '/cache';
         if ( $base ) {
@@ -719 +732 @@
         }
 
+    }
+
+    /**
+     * PHP4 constructor.
+     */
+    public function RSSCache( $base = '', $age = '' ) {
+        self::__construct( $base, $age );
     }