WordPress.org

Make WordPress Core


Ignore:
Timestamp:
06/28/2015 03:26:41 PM (4 years ago)
Author:
jorbin
Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rss.php

    r30201 r32990  
    5656    var $_CONTENT_CONSTRUCTS = array('content', 'summary', 'info', 'title', 'tagline', 'copyright');
    5757
    58     function MagpieRSS ($source) {
     58    /**
     59     * PHP5 constructor.
     60     */
     61    function __construct( $source ) {
    5962
    6063        # if PHP xml isn't compiled in, die
     
    9699
    97100        $this->normalize();
     101    }
     102
     103    /**
     104     * PHP4 constructor.
     105     */
     106    public function MagpieRSS( $source ) {
     107        self::__construct( $source );
    98108    }
    99109
     
    710720    var $ERROR      = '';           // accumulate error messages
    711721
    712     function RSSCache ($base='', $age='') {
     722    /**
     723     * PHP5 constructor.
     724     */
     725    function __construct( $base = '', $age = '' ) {
    713726        $this->BASE_CACHE = WP_CONTENT_DIR . '/cache';
    714727        if ( $base ) {
     
    719732        }
    720733
     734    }
     735
     736    /**
     737     * PHP4 constructor.
     738     */
     739    public function RSSCache( $base = '', $age = '' ) {
     740        self::__construct( $base, $age );
    721741    }
    722742
Note: See TracChangeset for help on using the changeset viewer.