Changeset 32990 for trunk/tests/phpunit/includes/utils.php

Timestamp:

06/28/2015 03:26:41 PM (9 years ago)

Author:

jorbin

Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: ​https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:

• trunk/tests/phpunit/includes/utils.php (modified) (3 diffs)

trunk/tests/phpunit/includes/utils.php

@@ -26 +26 @@
     var $debug;
 
-    function MockAction($debug=0) {
+    /**
+     * PHP5 constructor.
+     */
+    function __construct( $debug = 0 ) {
         $this->reset();
         $this->debug = $debug;
+    }
+
+    /**
+     * PHP4 constructor.
+     */
+    public function MockAction( $debug = 0 ) {
+        self::__construct( $debug );
     }
 
@@ -130 +140 @@
     var $data = array();
 
-    function testXMLParser($in) {
+    /**
+     * PHP5 constructor.
+     */
+    function __construct( $in ) {
         $this->xml = xml_parser_create();
         xml_set_object($this->xml, $this);
@@ -137 +150 @@
         xml_set_character_data_handler($this->xml, array($this, 'dataHandler'));
         $this->parse($in);
+    }
+
+    /**
+     * PHP4 constructor.
+     */
+    public function testXMLParser( $in ) {
+        self::__construct( $in );
     }