WordPress.org

Make WordPress Core


Ignore:
Timestamp:
06/28/2015 03:26:41 PM (4 years ago)
Author:
jorbin
Message:

Deprecate php4 style constructors

PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/includes/wp-profiler.php

    r29789 r32990  
    2222    var $profile;
    2323
    24     // constructor
    25     function WPProfiler() {
     24    /**
     25     * PHP5 constructor.
     26     */
     27    function __construct() {
    2628        $this->stack = array();
    2729        $this->profile = array();
     30    }
     31
     32    /**
     33     * PHP4 constructor.
     34     */
     35    public function WPProfiler() {
     36        self::__construct();
    2837    }
    2938
Note: See TracChangeset for help on using the changeset viewer.