Make WordPress Core


Ignore:
Timestamp:
07/01/2015 12:53:05 PM (9 years ago)
Author:
boonebgorges
Message:

Don't allow $field param to be passed to get_term_link().

The new parameter creates inconsistencies in the signatures of the various
functions for fetching term links (get_term_feed_link(),
get_edit_term_link(), etc.).

Reverts [32553].

See #14156.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/term/getTermLink.php

    r32553 r33022  
    4444
    4545    public function test_numeric_string_should_be_interpreted_as_term_slug() {
    46         $t1 = $this->factory->term->create( array(
    47             'taxonomy' => 'wptests_tax',
    48             'name' => 'foo',
    49         ) );
    50         $t2 = $this->factory->term->create( array(
    51             'taxonomy' => 'wptests_tax',
    52             'slug' => $t1,
    53         ) );
    54 
    55         $term = (string) $t1;
    56 
    57         $actual = get_term_link( $term, 'wptests_tax', 'id' );
    58         $this->assertContains( 'wptests_tax=foo', $actual );
    59     }
    60 
    61     /**
    62      * @ticket 14156
    63      */
    64     public function test_should_match_field_by_name() {
    65         $t = $this->factory->term->create( array(
    66             'taxonomy' => 'wptests_tax',
    67             'slug' => 'foo',
    68             'name' => 'Bar Term',
    69         ) );
    70 
    71         $actual = get_term_link( 'Bar Term', 'wptests_tax', 'name' );
    72         $this->assertContains( 'wptests_tax=foo', $actual );
    73     }
    74 
    75     /**
    76      * @ticket 14156
    77      */
    78     public function test_should_match_field_by_tt_id() {
    79         $t = $this->factory->term->create( array(
    80             'taxonomy' => 'wptests_tax',
    81             'slug' => 'foo',
    82             'name' => 'Bar Term',
    83         ) );
    84 
    85         $actual = get_term_link( 'Bar Term', 'wptests_tax', 'name' );
    86         $this->assertContains( 'wptests_tax=foo', $actual );
    87     }
    88 
    89     /**
    90      * @ticket 14156
    91      */
    92     public function test_numeric_string_should_be_interpreted_as_term_id_if_id_field_is_specified() {
    9346        $t1 = $this->factory->term->create( array(
    9447            'taxonomy' => 'wptests_tax',
Note: See TracChangeset for help on using the changeset viewer.