Changeset 33032

Timestamp:

07/01/2015 05:21:55 PM (11 years ago)

Author:

obenland

Message:

Add additional escaping to credits page.

Props Viper007Bond, gtuk for initial patch.
Fixes #21523.

File:

• trunk/src/wp-admin/credits.php (modified) (3 diffs)

trunk/src/wp-admin/credits.php

@@ -70 +70 @@
  */
 function _wp_credits_build_object_link( &$data ) {
-        $data = '<a href="' . esc_url( $data[1] ) . '">' . $data[0] . '</a>';
+        $data = '<a href="' . esc_url( $data[1] ) . '">' . esc_html( $data[0] ) . '</a>';
 }
 
@@ -121 +121 @@
                 }
 
-                echo '<h4 class="wp-people-group">' . $title . "</h4>\n";
+                echo '<h4 class="wp-people-group">' . esc_html( $title ) . "</h4>\n";
         }
 
@@ -141 +141 @@
                         echo '<ul class="' . $classes . '" id="wp-people-group-' . $group_slug . '">' . "\n";
                         foreach ( $group_data['data'] as $person_data ) {
-                                echo '<li class="wp-person" id="wp-person-' . $person_data[2] . '">' . "\n\t";
-                                echo '<a href="' . sprintf( $credits['data']['profiles'], $person_data[2] ) . '">';
+                                echo '<li class="wp-person" id="wp-person-' . esc_attr( $person_data[2] ) . '">' . "\n\t";
+                                echo '<a href="' . esc_url( sprintf( $credits['data']['profiles'], $person_data[2] ) ) . '">';
                                 $size = 'compact' == $group_data['type'] ? 30 : 60;
                                 $data = get_avatar_data( $person_data[1] . '@md5.gravatar.com', array( 'size' => $size ) );
                                 $size *= 2;
                                 $data2x = get_avatar_data( $person_data[1] . '@md5.gravatar.com', array( 'size' => $size ) );
-                                echo '<img src="' . esc_attr( $data['url'] ) . '" srcset="' . esc_attr( $data2x['url'] ) . ' 2x" class="gravatar" alt="' . esc_attr( $person_data[0] ) . '" /></a>' . "\n\t";
-                                echo '<a class="web" href="' . sprintf( $credits['data']['profiles'], $person_data[2] ) . '">' . $person_data[0] . "</a>\n\t";
+                                echo '<img src="' . esc_url( $data['url'] ) . '" srcset="' . esc_url( $data2x['url'] ) . ' 2x" class="gravatar" alt="' . esc_attr( $person_data[0] ) . '" /></a>' . "\n\t";
+                                echo '<a class="web" href="' . esc_url( sprintf( $credits['data']['profiles'], $person_data[2] ) ) . '">' . esc_html( $person_data[0] ) . "</a>\n\t";
                                 if ( ! $compact )
                                         echo '<span class="title">' . translate( $person_data[3] ) . "</span>\n";