Changeset 33041 for trunk/src/wp-includes/post.php

Timestamp:

07/02/2015 12:21:28 AM (9 years ago)

Author:

obenland

Message:

Turn of comments for pages by default.

Pages are static content, for which comments are not expected out of the box.

Props valendesigns, rachelbaker.
Fixes #31168.

File:

• trunk/src/wp-includes/post.php (modified) (4 diffs)

trunk/src/wp-includes/post.php

@@ -3128 +3128 @@
     $user_id = get_current_user_id();
 
-    $defaults = array('post_status' => 'draft', 'post_type' => 'post', 'post_author' => $user_id,
-        'ping_status' => get_option('default_ping_status'), 'post_parent' => 0,
-        'menu_order' => 0, 'to_ping' =>  '', 'pinged' => '', 'post_password' => '',
-        'guid' => '', 'post_content_filtered' => '', 'post_excerpt' => '', 'import_id' => 0,
-        'post_content' => '', 'post_title' => '', 'context' => '');
+    $defaults = array(
+        'post_author' => $user_id,
+        'post_content' => '',
+        'post_content_filtered' => '',
+        'post_title' => '',
+        'post_excerpt' => '',
+        'post_status' => 'draft',
+        'post_type' => 'post',
+        'comment_status' => '',
+        'ping_status' => '',
+        'post_password' => '',
+        'to_ping' =>  '',
+        'pinged' => '',
+        'post_parent' => 0,
+        'menu_order' => 0,
+        'guid' => '',
+        'import_id' => 0,
+        'context' => '',
+    );
 
     $postarr = wp_parse_args($postarr, $defaults);
@@ -3303 +3317 @@
     }
 
+    // Comment status.
     if ( empty( $postarr['comment_status'] ) ) {
         if ( $update ) {
             $comment_status = 'closed';
         } else {
-            $comment_status = get_option('default_comment_status');
+            $comment_status = get_default_comment_status( $post_type );
         }
     } else {
@@ -3316 +3331 @@
     $post_content_filtered = $postarr['post_content_filtered'];
     $post_author = empty( $postarr['post_author'] ) ? $user_id : $postarr['post_author'];
-    $ping_status = empty( $postarr['ping_status'] ) ? get_option( 'default_ping_status' ) : $postarr['ping_status'];
+    $ping_status = empty( $postarr['ping_status'] ) ? get_default_comment_status( $post_type, 'pingback' ) : $postarr['ping_status'];
     $to_ping = isset( $postarr['to_ping'] ) ? sanitize_trackback_urls( $postarr['to_ping'] ) : '';
     $pinged = isset( $postarr['pinged'] ) ? $postarr['pinged'] : '';
@@ -4057 +4072 @@
 
 //
-// Trackback and ping functions
+// Comment, trackback, and pingback functions.
 //
+
+/**
+ * Get the default comment status for a post type.
+ *
+ * @since 4.3.0
+ *
+ * @param  string $post_type    Optional. Post type. Default 'post'.
+ * @param  string $comment_type Optional. Comment type. Default 'comment'.
+ * @return string Expected return value is 'open' or 'closed'.
+ */
+function get_default_comment_status( $post_type = 'post', $comment_type = 'comment' ) {
+    switch ( $comment_type ) {
+        case 'pingback' :
+        case 'trackback' :
+            $supports = 'trackbacks';
+            $option = 'ping';
+            break;
+        default :
+            $supports = 'comments';
+            $option = 'comment';
+    }
+
+    // Set the status.
+    if ( 'page' === $post_type ) {
+        $status = 'closed';
+    } elseif ( post_type_supports( $post_type, $supports ) ) {
+        $status = get_option( "default_{$option}_status" );
+    } else {
+        $status = 'closed';
+    }
+
+    /**
+     * Filter the default comment status for the given post type.
+     *
+     * @since 4.3.0
+     *
+     * @param string $status       Default status for the given post type,
+     *                             either 'open' or 'closed'.
+     * @param string $comment_type Type of comment. Default is `comment`.
+     */
+    return apply_filters( "get_{$post_type}_default_comment_status", $status, $comment_type );
+}
 
 /**