Changeset 33083

Timestamp:

07/04/2015 05:52:46 AM (9 years ago)

Author:

jeremyfelt

Message:

Usernames in multisite should be restricted to 60 characters or fewer.

Only 60 characters can be stored in the database for a username, which could cause lookup issues when attempting to use similar usernames of extreme length.

Props @DJPaul.
See #17904, Fixes #26784.

Location:

trunk

Files:

• src/wp-includes/ms-functions.php (modified) (1 diff)
• tests/phpunit/tests/multisite/wpmuValidateUserSignup.php (modified) (1 diff)

trunk/src/wp-includes/ms-functions.php

@@ -494 +494 @@
     if ( strlen( $user_name ) < 4 )
         $errors->add('user_name',  __( 'Username must be at least 4 characters.' ) );
+
+    if ( strlen( $user_name ) > 60 ) {
+        $errors->add( 'user_name', __( 'Username may not be longer than 60 characters.' ) );
+    }
 
     if ( strpos( $user_name, '_' ) !== false )

trunk/tests/phpunit/tests/multisite/wpmuValidateUserSignup.php

@@ -27 +27 @@
             array( 'f', 'User names of 1 characters are not allowed.'  ),
             array( '12345', 'User names consisting only of numbers are not allowed.'  ),
+            array( 'thisusernamecontainsenoughcharacterstobelongerthan60characters', 'User names longer than 60 characters are not allowed.' ),
         );
     }