Changeset 33104 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

07/07/2015 03:11:54 PM (9 years ago)

Author:

helen

Message:

List tables: Add a fallback for the primary column.

Without a primary column defined, nothing shows in the responsive view at all, which is bad.

props mordauk.
see #25408.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -833 +833 @@
      */
     protected function get_default_primary_column_name() {
-        return '';
+        $columns = $this->get_columns();
+        $column = '';
+
+        // We need a primary defined so responsive views show something,
+        // so let's fall back to the first non-checkbox column.
+        foreach( $columns as $col => $column_name ) {
+            if ( 'cb' === $col ) {
+                continue;
+            }
+
+            $column = $col;
+            break;
+        }
+
+        return $column;
     }
 
@@ -879 +893 @@
             // Back-compat for list tables that have been manually setting $_column_headers for horse reasons.
             // In 4.3, we added a fourth argument for primary column.
-            $column_headers = array( array(), array(), array(), '' );
+            $column_headers = array( array(), array(), array(), $this->get_primary_column_name() );
             foreach ( $this->_column_headers as $key => $value ) {
                 $column_headers[ $key ] = $value;