Changeset 3314

Timestamp:

12/15/2005 10:20:06 PM (21 years ago)

Author:

ryan

Message:

Add post titles to site comment feed. Add some gettext. fixes #2067 #1987

Location:

trunk

Files:

• wp-commentsrss2.php (modified) (3 diffs)
• wp-includes/feed-functions.php (modified) (2 diffs)

trunk/wp-commentsrss2.php

@@ -21 +21 @@
                 $i++;
 ?>
-        <title><?php if (is_single() || is_page()) { echo "Comments on: "; the_title_rss(); } else { bloginfo_rss("name"); echo " Comments"; } ?></title>
+        <title><?php if (is_single() || is_page() ) { printf(__('Comments on: %s'), get_the_title_rss()); } else { printf(__('Comments for %s'), get_bloginfo_rss("name")); } ?></title>
         <link><?php (is_single()) ? permalink_single_rss() : bloginfo_rss("url") ?></link>
         <description><?php bloginfo_rss("description") ?></description>
@@ -52 +52 @@
 ?>
         <item>
-                <title>by: <?php comment_author_rss() ?></title>
+                <title><?php if ( ! (is_single() || is_page()) ) {
+                        $title = get_the_title($comment->comment_post_ID);
+                        $title = apply_filters('the_title', $title);
+                        $title = apply_filters('the_title_rss', $title);
+                        printf(__('Comment on %1$s by %2$s'), $title, get_comment_author_rss());
+                } else {        
+                        printf(__('by: %s'), get_comment_author_rss());                 
+                } ?></title>
                 <link><?php comment_link() ?></link>
                 <pubDate><?php echo mysql2date('D, d M Y H:i:s +0000', get_comment_time('Y-m-d H:i:s', true), false); ?></pubDate>
@@ -59 +66 @@
                         if (!empty($comment->post_password) && $_COOKIE['wp-postpass'] != $comment->post_password) {
                         ?>
-                <description>Protected Comments: Please enter your password to view comments.</description>
+                <description><?php _e('Protected Comments: Please enter your password to view comments.'); ?></description>
                 <content:encoded><![CDATA[<?php echo get_the_password_form() ?>]]></content:encoded>
                         <?php

trunk/wp-includes/feed-functions.php

@@ -10 +10 @@
 }
 
-function the_title_rss() {
+function get_the_title_rss() {
         $title = get_the_title();
         $title = apply_filters('the_title', $title);
         $title = apply_filters('the_title_rss', $title);
-        echo $title;
+        return $title;
+}
+
+function the_title_rss() {
+        echo get_the_title_rss();
 }
 
@@ -63 +67 @@
 }
 
+function get_comment_author_rss() {
+        return apply_filters('comment_author_rss', get_comment_author() );
+}
 function comment_author_rss() {
-        $author = apply_filters('comment_author_rss', get_comment_author() );
-        echo $author;
+        echo get_comment_author_rss();
 }