WordPress.org

Make WordPress Core

Changeset 33180


Ignore:
Timestamp:
07/12/2015 07:42:24 PM (6 years ago)
Author:
obenland
Message:

Site Icon: Improve a11y in Settings.

Props afercia.
Fixes #32970.

Location:
trunk/src/wp-admin
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/css/site-icon.css

    r33053 r33180  
    2727}
    2828
    29 .site-icon-crop-preview-shell h3 {
    30     margin-top: 0;
     29.site-icon-crop-preview-shell h2 {
     30    padding-top: 0;
    3131}
    3232
  • trunk/src/wp-admin/custom-header.php

    r32998 r33180  
    760760<form method="post" action="<?php echo esc_url(add_query_arg('step', 3)); ?>">
    761761    <p class="hide-if-no-js"><?php _e('Choose the part of the image you want to use as your header.'); ?></p>
    762     <p class="hide-if-js"><strong><?php _e( 'You need Javascript to choose a part of the image.'); ?></strong></p>
     762    <p class="hide-if-js"><strong><?php _e( 'You need JavaScript to choose a part of the image.'); ?></strong></p>
    763763
    764764    <div id="crop_image" style="position: relative">
  • trunk/src/wp-admin/includes/class-wp-site-icon.php

    r33154 r33180  
    267267                <form action="options-general.php" method="post" enctype="multipart/form-data">
    268268                    <p class="hide-if-no-js description"><?php _e('Choose the part of the image you want to use as your site icon.'); ?></p>
    269                     <p class="hide-if-js description"><strong><?php _e( 'You need Javascript to choose a part of the image.'); ?></strong></p>
     269                    <p class="hide-if-js description"><strong><?php _e( 'You need JavaScript to choose a part of the image.'); ?></strong></p>
    270270
    271271                    <div class="site-icon-crop-wrapper">
     
    274274
    275275                    <div class="site-icon-crop-preview-shell hide-if-no-js">
    276                         <h3><?php _e( 'Preview' ); ?></h3>
     276                        <h2><?php _e( 'Preview' ); ?></h2>
    277277                        <strong><?php _e( 'As a browser icon' ); ?></strong>
    278278                        <div class="site-icon-crop-favicon-preview-shell">
    279                             <img src="images/browser.png" class="site-icon-browser-preview" width="182" height="" alt="<?php esc_attr_e( 'Browser Chrome' ); ?>"/>
     279                            <img src="images/browser.png" class="site-icon-browser-preview" width="182" height="" alt=""/>
    280280
    281281                            <div class="site-icon-crop-preview-favicon">
    282                                 <img src="<?php echo esc_url( $url ); ?>" id="preview-favicon" alt="<?php esc_attr_e( 'Preview Favicon' ); ?>"/>
     282                                <img src="<?php echo esc_url( $url ); ?>" id="preview-favicon" alt="<?php esc_attr_e( 'Preview as a browser icon' ); ?>"/>
    283283                            </div>
    284284                            <span class="site-icon-browser-title"><?php bloginfo( 'name' ); ?></span>
     
    287287                        <strong><?php _e( 'As an app icon' ); ?></strong>
    288288                        <div class="site-icon-crop-preview-homeicon">
    289                             <img src="<?php echo esc_url( $url ); ?>" id="preview-homeicon" alt="<?php esc_attr_e( 'Preview Home Icon' ); ?>"/>
     289                            <img src="<?php echo esc_url( $url ); ?>" id="preview-homeicon" alt="<?php esc_attr_e( 'Preview as an app icon' ); ?>"/>
    290290                        </div>
    291291                    </div>
  • trunk/src/wp-admin/options-general.php

    r33154 r33180  
    126126</tr>
    127127<tr>
    128 <th scope="row"><label for="site_icon"><?php _e( 'Site Icon' ); ?></label></th>
     128<th scope="row"><?php _e( 'Site Icon' ); ?></th>
    129129<td>
    130130    <?php
     
    144144    ?>
    145145
    146     <img class="avatar avatar-150" src="<?php site_icon_url( null, 150 ); ?>" height="150" width="150" />
     146    <img class="avatar avatar-150" src="<?php site_icon_url( null, 150 ); ?>" height="150" width="150" alt="" />
    147147    <p class="hide-if-no-js">
    148         <label class="screen-reader-text" for="choose-from-library-link"><?php _e( 'Choose an image from your media library:' ); ?></label>
    149148        <button type="button" id="choose-from-library-link" class="button" data-size="<?php echo absint( $GLOBALS['wp_site_icon']->min_size ); ?>" data-update-link="<?php echo esc_attr( $update_url ); ?>" data-choose="<?php esc_attr_e( 'Choose a Site Icon' ); ?>" data-update="<?php esc_attr_e( 'Set as Site Icon' ); ?>"><?php _e( 'Update Site Icon' ); ?></button>
    150149        <a href="<?php echo esc_url( $remove_url ); ?>"><?php _e( 'Remove Site Icon' ); ?></a>
     
    158157
    159158    <p class="hide-if-no-js">
    160         <label class="screen-reader-text" for="choose-from-library-link"><?php _e( 'Choose an image from your media library:' ); ?></label>
    161         <button type="button" id="choose-from-library-link" class="button" data-size="<?php echo absint( $GLOBALS['wp_site_icon']->min_size ); ?>" data-update-link="<?php echo esc_attr( $update_url ); ?>" data-choose="<?php esc_attr_e( 'Choose a Site Icon' ); ?>" data-update="<?php esc_attr_e( 'Set as Site Icon' ); ?>"><?php _e( 'Choose Image' ); ?></button>
     159        <button type="button" id="choose-from-library-link" class="button" data-size="<?php echo absint( $GLOBALS['wp_site_icon']->min_size ); ?>" data-update-link="<?php echo esc_attr( $update_url ); ?>" data-choose="<?php esc_attr_e( 'Choose a Site Icon' ); ?>" data-update="<?php esc_attr_e( 'Set as Site Icon' ); ?>" aria-label="<?php esc_attr_e( 'Choose an image from your media library' ); ?>" aria-describedby="site-icon-description"><?php _e( 'Choose Image' ); ?></button>
    162160    </p>
    163161    <a class="button hide-if-js" href="<?php echo esc_url( $upload_url ); ?>"><?php _e( 'Add a Site Icon' ); ?></a>
    164162
    165163    <?php endif; ?>
    166     <p class="description"><?php _e( 'The Site Icon is used as a browser and app icon for your site.' ); ?></p>
     164    <p id="site-icon-description" class="description"><?php _e( 'The Site Icon is used as a browser and app icon for your site.' ); ?></p>
    167165</td>
    168166</tr>
Note: See TracChangeset for help on using the changeset viewer.