WordPress.org

Make WordPress Core


Ignore:
Timestamp:
07/12/2015 07:42:24 PM (5 years ago)
Author:
obenland
Message:

Site Icon: Improve a11y in Settings.

Props afercia.
Fixes #32970.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-site-icon.php

    r33154 r33180  
    267267                <form action="options-general.php" method="post" enctype="multipart/form-data">
    268268                    <p class="hide-if-no-js description"><?php _e('Choose the part of the image you want to use as your site icon.'); ?></p>
    269                     <p class="hide-if-js description"><strong><?php _e( 'You need Javascript to choose a part of the image.'); ?></strong></p>
     269                    <p class="hide-if-js description"><strong><?php _e( 'You need JavaScript to choose a part of the image.'); ?></strong></p>
    270270
    271271                    <div class="site-icon-crop-wrapper">
     
    274274
    275275                    <div class="site-icon-crop-preview-shell hide-if-no-js">
    276                         <h3><?php _e( 'Preview' ); ?></h3>
     276                        <h2><?php _e( 'Preview' ); ?></h2>
    277277                        <strong><?php _e( 'As a browser icon' ); ?></strong>
    278278                        <div class="site-icon-crop-favicon-preview-shell">
    279                             <img src="images/browser.png" class="site-icon-browser-preview" width="182" height="" alt="<?php esc_attr_e( 'Browser Chrome' ); ?>"/>
     279                            <img src="images/browser.png" class="site-icon-browser-preview" width="182" height="" alt=""/>
    280280
    281281                            <div class="site-icon-crop-preview-favicon">
    282                                 <img src="<?php echo esc_url( $url ); ?>" id="preview-favicon" alt="<?php esc_attr_e( 'Preview Favicon' ); ?>"/>
     282                                <img src="<?php echo esc_url( $url ); ?>" id="preview-favicon" alt="<?php esc_attr_e( 'Preview as a browser icon' ); ?>"/>
    283283                            </div>
    284284                            <span class="site-icon-browser-title"><?php bloginfo( 'name' ); ?></span>
     
    287287                        <strong><?php _e( 'As an app icon' ); ?></strong>
    288288                        <div class="site-icon-crop-preview-homeicon">
    289                             <img src="<?php echo esc_url( $url ); ?>" id="preview-homeicon" alt="<?php esc_attr_e( 'Preview Home Icon' ); ?>"/>
     289                            <img src="<?php echo esc_url( $url ); ?>" id="preview-homeicon" alt="<?php esc_attr_e( 'Preview as an app icon' ); ?>"/>
    290290                        </div>
    291291                    </div>
Note: See TracChangeset for help on using the changeset viewer.