Changeset 3322

Timestamp:

12/18/2005 03:49:43 PM (19 years ago)

Author:

ryan

Message:

Fix ping races. fixes #2088

File:

• trunk/wp-admin/execute-pings.php (modified) (1 diff)

trunk/wp-admin/execute-pings.php

@@ -8 +8 @@
     global $wpdb;
     // Do pingbacks
-    if($pings = $wpdb->get_results("SELECT * FROM {$wpdb->posts}, {$wpdb->postmeta} WHERE {$wpdb->posts}.ID = {$wpdb->postmeta}.post_id AND {$wpdb->postmeta}.meta_key = '_pingme';")) {
-        foreach($pings as $ping) {
-            pingback($ping->post_content, $ping->ID);
-            echo "Pingback: $ping->post_title : $ping->ID<br/>";
-            $wpdb->query("DELETE FROM {$wpdb->postmeta} WHERE post_id = {$ping->ID} AND meta_key = '_pingme';");
-        }
+    while ($ping = $wpdb->get_row("SELECT * FROM {$wpdb->posts}, {$wpdb->postmeta} WHERE {$wpdb->posts}.ID = {$wpdb->postmeta}.post_id AND {$wpdb->postmeta}.meta_key = '_pingme' LIMIT 1")) {
+        $wpdb->query("DELETE FROM {$wpdb->postmeta} WHERE post_id = {$ping->ID} AND meta_key = '_pingme';");
+        pingback($ping->post_content, $ping->ID);
+        echo "Pingback: $ping->post_title : $ping->ID<br/>";
     }
     // Do Enclosures
-    if($enclosures = $wpdb->get_results("SELECT * FROM {$wpdb->posts}, {$wpdb->postmeta} WHERE {$wpdb->posts}.ID = {$wpdb->postmeta}.post_id AND {$wpdb->postmeta}.meta_key = '_encloseme';")) {
-        foreach($enclosures as $enclosure) {
-            do_enclose($enclosure->post_content, $enclosure->ID);
-            echo "Enclosure: $enclosure->post_title : $enclosure->ID<br/>";
-            $wpdb->query("DELETE FROM {$wpdb->postmeta} WHERE post_id = {$enclosure->ID} AND meta_key = '_encloseme';");
-        }
+    while ($enclosure = $wpdb->get_row("SELECT * FROM {$wpdb->posts}, {$wpdb->postmeta} WHERE {$wpdb->posts}.ID = {$wpdb->postmeta}.post_id AND {$wpdb->postmeta}.meta_key = '_encloseme' LIMIT 1")) {
+        $wpdb->query("DELETE FROM {$wpdb->postmeta} WHERE post_id = {$enclosure->ID} AND meta_key = '_encloseme';");
+        do_enclose($enclosure->post_content, $enclosure->ID);
+        echo "Enclosure: $enclosure->post_title : $enclosure->ID<br/>";
     }
     // Do Trackbacks
-    if($trackbacks = $wpdb->get_results("SELECT ID FROM $wpdb->posts WHERE TRIM(to_ping) != '' AND post_status != 'draft'")) {
-        foreach($trackbacks as $trackback) {
-            echo "Trackback : $trackback->ID<br/>";
-            do_trackbacks($trackback->ID);
-        }
+    while ($trackback = $wpdb->get_row("SELECT ID FROM $wpdb->posts WHERE TRIM(to_ping) != '' AND post_status != 'draft' LIMIT 1")) {
+        echo "Trackback : $trackback->ID<br/>";
+        do_trackbacks($trackback->ID);
     }
 }