Changeset 33261

Timestamp:

07/14/2015 12:27:03 PM (9 years ago)

Author:

boonebgorges

Message:

When creating a new post with an empty post_name and post_title, don't generate a post_name that conflicts with a date archive permalink.

See #5305.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -3452 +3452 @@
 
     if ( empty( $data['post_name'] ) && ! in_array( $data['post_status'], array( 'draft', 'pending', 'auto-draft' ) ) ) {
-        $data['post_name'] = sanitize_title( $data['post_title'], $post_ID );
+        $data['post_name'] = wp_unique_post_slug( sanitize_title( $data['post_title'], $post_ID ), $post_ID, $data['post_status'], $post_type, $post_parent );
         $wpdb->update( $wpdb->posts, array( 'post_name' => $data['post_name'] ), $where );
     }

trunk/tests/phpunit/tests/post.php

@@ -413 +413 @@
 
     /**
+     * @ticket 5305
+     */
+    public function test_wp_insert_post_should_not_allow_a_bare_numeric_slug_that_might_conflict_with_a_date_archive_when_generating_from_an_empty_post_title() {
+        global $wp_rewrite;
+        $wp_rewrite->init();
+        $wp_rewrite->set_permalink_structure( '/%postname%/' );
+        $wp_rewrite->flush_rules();
+
+        $p = wp_insert_post( array(
+            'post_title' => '',
+            'post_content' => 'test',
+            'post_status' => 'publish',
+            'post_type' => 'post',
+        ) );
+
+        $post = get_post( $p );
+
+        $wp_rewrite->set_permalink_structure( '' );
+
+        $this->assertEquals( "$p-2", $post->post_name );
+    }
+
+    /**
      * @ticket 5364
      */