Changeset 33266 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

07/14/2015 04:17:06 PM (10 years ago)

Author:

helen

Message:

List tables: Even more robust fallback for the primary column.

Since WP_List_Table::get_default_primary_column() can be overridden in a subclass and columns can be further filtered, it is possible to end up with a primary column that no longer exists. This is particularly evident in list tables for custom post types that have been altered via filter.

props ocean90.
fixes #32996.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -888 +888 @@
         $default = $this->get_default_primary_column_name();
 
+        // If the primary column doesn't exist fall back to the
+        // first non-checkbox column.
+        if ( ! isset( $columns[ $default ] ) ) {
+            $default = WP_List_Table::get_default_primary_column_name();
+        }
+
         /**
          * Filter the name of the primary column for the current list table.