Changeset 33270 for trunk/src/wp-admin/includes/class-wp-links-list-table.php

Timestamp:

07/14/2015 05:46:13 PM (10 years ago)

Author:

wonderboymusic

Message:

List Tables:

• In ->handle_row_actions(), bail immediately if $primary and $column_name do not match. Saves us a nesting level and avoids declaring code that is unusable.
• In WP_List_Table::single_row_columns(), allow _column_{$name} to be called dynamically by core to avoid having to override the entirety of ->single_row_columns() in WP_MS_Users_List_Table and WP_Posts_List_Table
• In WP_MS_Sites_List_Table, id is not a column.

Props wonderboymusic, paulwilde.
Fixes #29881.

File:

• trunk/src/wp-admin/includes/class-wp-links-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-links-list-table.php

@@ -311 +311 @@
      */
     protected function handle_row_actions( $link, $column_name, $primary ) {
-        if ( $primary === $column_name ) {
-            $edit_link = get_edit_bookmark_link( $link );
-
-            $actions = array();
-            $actions['edit'] = '<a href="' . $edit_link . '">' . __('Edit') . '</a>';
-            $actions['delete'] = "<a class='submitdelete' href='" . wp_nonce_url("link.php?action=delete&amp;link_id=$link->link_id", 'delete-bookmark_' . $link->link_id) . "' onclick=\"if ( confirm( '" . esc_js(sprintf(__("You are about to delete this link '%s'\n  'Cancel' to stop, 'OK' to delete."), $link->link_name)) . "' ) ) { return true;}return false;\">" . __('Delete') . "</a>";
-            return $this->row_actions($actions);
+        if ( $primary !== $column_name ) {
+            return '';
         }
+
+        $edit_link = get_edit_bookmark_link( $link );
+
+        $actions = array();
+        $actions['edit'] = '<a href="' . $edit_link . '">' . __('Edit') . '</a>';
+        $actions['delete'] = "<a class='submitdelete' href='" . wp_nonce_url("link.php?action=delete&amp;link_id=$link->link_id", 'delete-bookmark_' . $link->link_id) . "' onclick=\"if ( confirm( '" . esc_js(sprintf(__("You are about to delete this link '%s'\n  'Cancel' to stop, 'OK' to delete."), $link->link_name)) . "' ) ) { return true;}return false;\">" . __('Delete') . "</a>";
+        return $this->row_actions( $actions );
     }
 }