Changeset 33270 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

07/14/2015 05:46:13 PM (11 years ago)

Author:

wonderboymusic

Message:

List Tables:

• In ->handle_row_actions(), bail immediately if $primary and $column_name do not match. Saves us a nesting level and avoids declaring code that is unusable.
• In WP_List_Table::single_row_columns(), allow _column_{$name} to be called dynamically by core to avoid having to override the entirety of ->single_row_columns() in WP_MS_Users_List_Table and WP_Posts_List_Table
• In WP_MS_Sites_List_Table, id is not a column.

Props wonderboymusic, paulwilde.
Fixes #29881.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -1225 +1225 @@
                                 echo $this->column_cb( $item );
                                 echo '</th>';
-                        }
-                        elseif ( method_exists( $this, 'column_' . $column_name ) ) {
+                        } elseif ( method_exists( $this, '_column_' . $column_name ) ) {
+                                echo call_user_func(
+                                        array( $this, '_column_' . $column_name ),
+                                        $item,
+                                        $classes,
+                                        $data,
+                                        $primary
+                                );
+                        } elseif ( method_exists( $this, 'column_' . $column_name ) ) {
                                 echo "<td $attributes>";
                                 echo call_user_func( array( $this, 'column_' . $column_name ), $item );
                                 echo $this->handle_row_actions( $item, $column_name, $primary );
                                 echo "</td>";
-                        }
-                        else {
+                        } else {
                                 echo "<td $attributes>";
                                 echo $this->column_default( $item, $column_name );