Changeset 33270 for trunk/src/wp-admin/includes/class-wp-media-list-table.php

Timestamp:

07/14/2015 05:46:13 PM (11 years ago)

Author:

wonderboymusic

Message:

List Tables:

• In ->handle_row_actions(), bail immediately if $primary and $column_name do not match. Saves us a nesting level and avoids declaring code that is unusable.
• In WP_List_Table::single_row_columns(), allow _column_{$name} to be called dynamically by core to avoid having to override the entirety of ->single_row_columns() in WP_MS_Users_List_Table and WP_Posts_List_Table
• In WP_MS_Sites_List_Table, id is not a column.

Props wonderboymusic, paulwilde.
Fixes #29881.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -648 +648 @@
          */
         protected function handle_row_actions( $post, $column_name, $primary ) {
-                if ( $primary === $column_name ) {
-                        $att_title = _draft_or_post_title();
-                        return $this->row_actions( $this->_get_row_actions( $post, $att_title ) );
-                }
+                if ( $primary !== $column_name ) {
+                        return '';
+                }
+
+                $att_title = _draft_or_post_title();
+                return $this->row_actions( $this->_get_row_actions( $post, $att_title ) );
         }
 }