Changeset 33271 for trunk/tests/phpunit/tests/formatting/WPSpecialchars.php

Timestamp:

07/14/2015 05:55:07 PM (11 years ago)

Author:

wonderboymusic

Message:

After [33148]:
Don't nest esc_attr() and htmlspecialchars() when escaping the post title on the edit post screen.

Unrevert parts of [32851] and [32850].

Adds/alters unit tests.

Props miqrogroove.
Fixes #17780.

File:

• trunk/tests/phpunit/tests/formatting/WPSpecialchars.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/WPSpecialchars.php

@@ -18 +18 @@
                 // Allowed entities should be unchanged
                 foreach ( $allowedentitynames as $ent ) {
+                        if ( 'apos' == $ent ) {
+                                // But for some reason, PHP doesn't allow '
+                                continue;
+                        }
                         $ent = '&' . $ent . ';';
                         $this->assertEquals( $ent, _wp_specialchars( $ent ) );
@@ -40 +44 @@
                 $this->assertEquals( $source, _wp_specialchars($source) );
         }
+
+        /**
+         * Check some of the double-encoding features for entity references.
+         *
+         * @ticket 17780
+         * @dataProvider data_double_encoding
+         */
+        function test_double_encoding( $input, $output ) {
+                return $this->assertEquals( $output, _wp_specialchars( $input, ENT_NOQUOTES, false, true ) );
+        }
+
+        function data_double_encoding() {
+                return array(
+                        array(
+                                'This & that, this & that, — " " Ú   " " " " " $ ×',
+                                'This & that, this & that, — " " Ú   " " " " " $ ×',
+                        ),
+                        array(
+                                '&& && && &;',
+                                '&& && && &;',
+                        ),
+                        array(
+                                '&garbage; &***; &aaaa; &0000; &####; &;;',
+                                '&garbage; &***; &aaaa; &0000; &####; &;;',
+                        ),
+                );
+        }
+
+        /**
+         * Check some of the double-encoding features for entity references.
+         *
+         * @ticket 17780
+         * @dataProvider data_no_double_encoding
+         */
+        function test_no_double_encoding( $input, $output ) {
+                return $this->assertEquals( $output, _wp_specialchars( $input, ENT_NOQUOTES, false, false ) );
+        }
+
+        function data_no_double_encoding() {
+                return array(
+                        array(
+                                'This & that, this & that, — " " Ú   " " " " " $ ×',
+                                'This & that, this & that, — " " Ú   " " " " " $ ×',
+                        ),
+                        array(
+                                '&& && && &;',
+                                '&& && && &;',
+                        ),
+                        array(
+                                '&garbage; &***; &aaaa; &0000; &####; &;;',
+                                '&garbage; &***; &aaaa; &0000; &####; &;;',
+                        ),
+                );
+        }
 }