Changeset 33277

Timestamp:

07/15/2015 04:39:19 AM (9 years ago)

Author:

pento

Message:

WPDB: When checking that text isn't too long to insert into a column, LONGTEXT columns could fail, as their length is longer than PHP_INT_MAX. Treating their length as a float instead of an int fixes this.

Merge of [33276] to the 4.2 branch.

See #32165.

File:

• branches/4.2/src/wp-includes/wp-db.php (modified) (1 diff)

branches/4.2/src/wp-includes/wp-db.php

@@ -2683 +2683 @@
                     if ( 'byte' === $value['length']['type'] ) {
                         // Split the CONVERT() calls by charset, so we can make sure the connection is right
-                        $queries[ $value['charset'] ][ $col ] = $this->prepare( "CONVERT( LEFT( CONVERT( %s USING binary ), %d ) USING {$value['charset']} )", $value['value'], $value['length']['length'] );
+                        $queries[ $value['charset'] ][ $col ] = $this->prepare( "CONVERT( LEFT( CONVERT( %s USING binary ), %.0f ) USING {$value['charset']} )", $value['value'], $value['length']['length'] );
                     } else {
-                        $queries[ $value['charset'] ][ $col ] = $this->prepare( "LEFT( CONVERT( %s USING {$value['charset']} ), %d )", $value['value'], $value['length']['length'] );
+                        $queries[ $value['charset'] ][ $col ] = $this->prepare( "LEFT( CONVERT( %s USING {$value['charset']} ), %.0f )", $value['value'], $value['length']['length'] );
                     }