Changeset 33339 for trunk/src/wp-includes/class-wp-customize-control.php

Timestamp:

07/21/2015 11:36:15 AM (11 years ago)

Author:

ocean90

Message:

Customizer: Avoid duplicate IDs and remove role presentation from menu items reorder button. Follow-up to [33074].

props afercia.
fixes #32725.

File:

• trunk/src/wp-includes/class-wp-customize-control.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-control.php

@@ -1575 +1575 @@
                         <?php _e( 'Add Items' ); ?>
                 </button>
-                <button type="button" role="presentation" class="not-a-button reorder-toggle" tabindex="-1">
-                        <span class="reorder" tabindex="0" role="button" aria-label="<?php esc_attr_e( 'Reorder menu items' ); ?>" aria-describedby="reorder-items-desc"><?php _ex( 'Reorder', 'Reorder menu items in Customizer' ); ?></span>
-                        <span class="reorder-done" tabindex="0" role="button" aria-label="<?php esc_attr_e( 'Close reorder mode' ); ?>"><?php _ex( 'Done', 'Cancel reordering menu items in Customizer' ); ?></span>
+                <button type="button" class="not-a-button reorder-toggle" aria-label="<?php esc_attr_e( 'Reorder menu items' ); ?>" aria-describedby="reorder-items-desc-{{ data.menu_id }}">
+                        <span class="reorder"><?php _ex( 'Reorder', 'Reorder menu items in Customizer' ); ?></span>
+                        <span class="reorder-done"><?php _ex( 'Done', 'Cancel reordering menu items in Customizer' ); ?></span>
                 </button>
-                <p class="screen-reader-text" id="reorder-items-desc"><?php _e( 'When in reorder mode, additional controls to reorder menu items will be available in the items list above.' ); ?></p>
+                <p class="screen-reader-text" id="reorder-items-desc-{{ data.menu_id }}"><?php _e( 'When in reorder mode, additional controls to reorder menu items will be available in the items list above.' ); ?></p>
                 <span class="add-menu-item-loading spinner"></span>
                 <span class="menu-delete-item">