Changeset 33438

Timestamp:

07/27/2015 03:12:55 AM (10 years ago)

Author:

markjaquith

Message:

Toggle between dashicons-hidden and dashicons-visibility in the password hide/show button.

fixes #33135

Location:

trunk/src/wp-admin

Files:

• install.php (modified) (1 diff)
• js/user-profile.js (modified) (2 diffs)
• user-edit.php (modified) (1 diff)
• user-new.php (modified) (1 diff)

trunk/src/wp-admin/install.php

@@ -142 +142 @@
                     <input type="password" name="admin_password" id="pass1" class="regular-text" autocomplete="off" data-reveal="1" data-pw="<?php echo esc_attr( $initial_password ); ?>" aria-describedby="pass-strength-result" />
                     <button type="button" class="button button-secondary wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
-                        <span class="dashicons dashicons-visibility"></span>
+                        <span class="dashicons dashicons-hidden"></span>
                         <span class="text"><?php _e( 'Hide' ); ?></span>
                     </button>

trunk/src/wp-admin/js/user-profile.js

@@ -144 +144 @@
                 pwWrapper.addClass( 'show-password' );
                 pw_togglebtn.attr({ 'data-toggle': 0, 'aria-label': userProfileL10n.ariaHide })
-                    .find( '.text' ).text( userProfileL10n.hide )
-                ;
+                    .find( '.text' ).text( userProfileL10n.hide );
+                pw_togglebtn.find( '.dashicons' ).removeClass('dashicons-visibility').addClass('dashicons-hidden');
                 pwFieldText.focus();
                 if ( ! _.isUndefined( pwFieldText[0].setSelectionRange ) ) {
@@ -154 +154 @@
                 pw_togglebtn.attr({ 'data-toggle': 1, 'aria-label': userProfileL10n.ariaShow })
                     .find( '.text' ).text( userProfileL10n.show );
+                pw_togglebtn.find( '.dashicons' ).removeClass('dashicons-hidden').addClass('dashicons-visibility');
                 pw_field.focus();
                 if ( ! _.isUndefined( pw_field[0].setSelectionRange ) ) {

trunk/src/wp-admin/user-edit.php

@@ -471 +471 @@
             <input type="password" name="pass1" id="pass1" class="regular-text" value="" autocomplete="off" data-pw="<?php echo esc_attr( wp_generate_password( 24 ) ); ?>" aria-describedby="pass-strength-result" />
             <button type="button" class="button button-secondary wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
-                <span class="dashicons dashicons-visibility"></span>
+                <span class="dashicons dashicons-hidden"></span>
                 <span class="text"><?php _e( 'Hide' ); ?></span>
             </button>

trunk/src/wp-admin/user-new.php

@@ -405 +405 @@
                 <input type="password" name="pass1" id="pass1" class="regular-text" autocomplete="off" data-reveal="1" data-pw="<?php echo esc_attr( $initial_password ); ?>" aria-describedby="pass-strength-result" />
                 <button type="button" class="button button-secondary wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
-                    <span class="dashicons dashicons-visibility"></span>
+                    <span class="dashicons dashicons-hidden"></span>
                     <span class="text"><?php _e( 'Hide' ); ?></span>
                 </button>