Changeset 33465

Timestamp:

07/28/2015 09:10:16 PM (10 years ago)

Author:

markjaquith

Message:

Lose the clunky setTimeout() code and just track the password value changes.

see #32886

File:

• trunk/src/wp-admin/js/user-profile.js (modified) (2 diffs)

trunk/src/wp-admin/js/user-profile.js

@@ -28 +28 @@
     function bindPass1() {
         var passStrength = $('#pass-strength-result')[0];
+        var currentPass = $pass1.val();
 
         $pass1Wrap = $pass1.parent();
@@ -51 +52 @@
 
         $pass1.on( 'input propertychange', function () {
-            setTimeout( function () {
-                $pass1Text.val( $pass1.val() );
-                $pass1.add( $pass1Text ).removeClass( 'short bad good strong' );
-
-                if ( passStrength.className ) {
-                    $pass1.add( $pass1Text ).addClass( passStrength.className );
-                    if ( 'short' === passStrength.className || 'bad' === passStrength.className ) {
-                        if ( ! $weakCheckbox.prop( 'checked' ) ) {
-                            $submitButtons.prop( 'disabled', true );
-                        }
-                        $weakRow.show();
-                    } else {
-                        $submitButtons.prop( 'disabled', false );
-                        $weakRow.hide();
-                    }
-                }
-            }, 1 );
+            if ( $pass1.val() === currentPass ) {
+                return;
+            }
+
+            currentPass = $pass1.val();
+            $pass1Text.val( currentPass );
+            $pass1.add( $pass1Text ).removeClass( 'short bad good strong' );
+
+            if ( passStrength.className ) {
+                $pass1.add( $pass1Text ).addClass( passStrength.className );
+                if ( 'short' === passStrength.className || 'bad' === passStrength.className ) {
+                    if ( ! $weakCheckbox.prop( 'checked' ) ) {
+                        $submitButtons.prop( 'disabled', true );
+                    }
+                    $weakRow.show();
+                } else {
+                    $submitButtons.prop( 'disabled', false );
+                    $weakRow.hide();
+                }
+            }
         } );
     }